Skip to content

refactor external scaler#6829

Merged
JorTurFer merged 4 commits intokedacore:mainfrom
dttung2905:refactor-external-scaler
Jun 21, 2025
Merged

refactor external scaler#6829
JorTurFer merged 4 commits intokedacore:mainfrom
dttung2905:refactor-external-scaler

Conversation

@dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jun 9, 2025 •
edited
Loading

Checklist

Relates to #5797

@dttung2905
refactor external scaler
ca4435f 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner June 9, 2025 20:13
@dttung2905
Fix ci lint error
b6c7b8d 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Copy link
Contributor Author

dttung2905 commented Jun 10, 2025 •
edited by github-actions bot
Loading

/run-e2e external

Update: You can check the progress here

@wozniakjan wozniakjan requested a review from Copilot June 11, 2025 10:47
Copilot AI reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dttung2905
Fix CI Failure
8a4594b 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Copy link
Contributor Author

dttung2905 commented Jun 11, 2025

@wozniakjan not sure why the e2e command failed with

Run MESSAGE="$COMMENT_BODY"
bash: line 1: /go/bin/golangci-lint: No such file or directory
go run -tags e2e ./tests/run-all.go regex-check
No test has been executed, please review your regex: 'external
'
exit status 1
make: *** [Makefile:107: e2e-regex-check] Error 1

where previous PR that runs this command passes 🤔

@dttung2905
Copy link
Contributor Author

dttung2905 commented Jun 16, 2025 •
edited by github-actions bot
Loading

/run-e2e external_scaler

Update: You can check the progress here

@dttung2905
Copy link
Contributor Author

dttung2905 commented Jun 16, 2025 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! <3

@wozniakjan not sure why the e2e command failed with

hmm, looks like a glitch in CI..

@JorTurFer
Copy link
Member

JorTurFer commented Jun 21, 2025 •
edited by github-actions bot
Loading

/run-e2e external_scaler
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) June 21, 2025 19:48
@JorTurFer JorTurFer merged commit 75f589a into kedacore:main Jun 21, 2025
23 checks passed
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
@dttung2905 @JorTurFer @dpochopsky
refactor external scaler (kedacore#6829)
e05b0d4 
* refactor external scaler

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Fix ci lint error

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Fix CI Failure

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
@dttung2905 dttung2905 mentioned this pull request Oct 16, 2025
Open
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dttung2905 @JorTurFer @wozniakjan