Fix: Prefixes in envFrom within deployment specs are being ignored#6757
Merged
JorTurFer merged 5 commits intokedacore:mainfrom May 13, 2025
Merged
Fix: Prefixes in envFrom within deployment specs are being ignored#6757JorTurFer merged 5 commits intokedacore:mainfrom
JorTurFer merged 5 commits intokedacore:mainfrom
Conversation
When envFrom includes a prefix setting, the scale resolver ignores this prefix and adds environment variable keys to the ScalerConfig without the prefix. This fix modifies resolveEnv to correctly apply prefixes to keys when a prefix is specified. Signed-off-by: araminian <rmin.aminian@gmail.com>
Signed-off-by: araminian <rmin.aminian@gmail.com>
Signed-off-by: araminian <rmin.aminian@gmail.com>
Signed-off-by: araminian <rmin.aminian@gmail.com>
Member
|
/run-e2e |
JorTurFer
approved these changes
May 13, 2025
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Member
|
/run-e2e rabbit |
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…edacore#6757) * fix: Prefixes in envFrom within deployment specs are being ignored When envFrom includes a prefix setting, the scale resolver ignores this prefix and adds environment variable keys to the ScalerConfig without the prefix. This fix modifies resolveEnv to correctly apply prefixes to keys when a prefix is specified. Signed-off-by: araminian <rmin.aminian@gmail.com> * Reorder changelog Signed-off-by: araminian <rmin.aminian@gmail.com> * Use existing test function Signed-off-by: araminian <rmin.aminian@gmail.com> * Adjust comment Signed-off-by: araminian <rmin.aminian@gmail.com> --------- Signed-off-by: araminian <rmin.aminian@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When envFrom includes a prefix setting, the scale resolver ignores this prefix and adds environment variable keys to the ScalerConfig without the prefix.
resolveEnvis ignoring theprefixsetting and loading envs withoutprefix:Actual:
Desired:
Provide a description of what has been changed.
FIX
resolveEnvcorrectly applies prefixes to keys when a prefix is specified.prefix, prefix is an empty string if not setEnv Key:prefix + kChecklist
Fixes #6728