Skip to content

Refactor MSSQL scaler#6714

Merged
zroubalik merged 3 commits intokedacore:mainfrom
rickbrouwer:mssql-refactor
Jul 21, 2025
Merged

Refactor MSSQL scaler#6714
zroubalik merged 3 commits intokedacore:mainfrom
rickbrouwer:mssql-refactor

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Apr 12, 2025

Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner April 12, 2025 15:20
@rickbrouwer rickbrouwer force-pushed the mssql-refactor branch 7 times, most recently from b48a2e5 to 1fc3928 Compare April 12, 2025 16:25
@SpiritZhou
Copy link
Contributor

SpiritZhou commented Apr 14, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

SpiritZhou
SpiritZhou reviewed Apr 21, 2025
View reviewed changes
@rickbrouwer rickbrouwer force-pushed the mssql-refactor branch 6 times, most recently from ccc8fbf to 5cdc44b Compare April 21, 2025 08:51
JorTurFer
JorTurFer reviewed Apr 21, 2025
View reviewed changes
@zroubalik
Copy link
Member

zroubalik commented Apr 24, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Apr 26, 2025

e2e test are failing because of an error:

"error": "error establishing mssql connection: mssql: login error: Login failed for user ''."***

@rickbrouwer
Copy link
Member Author

rickbrouwer commented Apr 26, 2025 •
edited
Loading

e2e test are failing because of an error:

"error": "error establishing mssql connection: mssql: login error: Login failed for user ''."***

Yes, thanks. I will look into it asap.

@rickbrouwer
Copy link
Member Author

rickbrouwer commented Apr 26, 2025

e2e test are failing because of an error:

"error": "error establishing mssql connection: mssql: login error: Login failed for user ''."***

Fixed :)

@JorTurFer
Copy link
Member

JorTurFer commented Apr 26, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@dttung2905 dttung2905 mentioned this pull request Jun 9, 2025
Open
58 tasks
@stale
Copy link

stale bot commented Jun 25, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 25, 2025
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Jun 26, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 26, 2025
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Jul 4, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

zroubalik
zroubalik requested changes Jul 7, 2025
View reviewed changes
@rickbrouwer
Refactor MSSQL scaler
4a377f1 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Jul 8, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@rickbrouwer
Copy link
Member Author

rickbrouwer commented Jul 8, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) July 21, 2025 15:19
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Jul 21, 2025 •
edited by github-actions bot
Loading

/run-e2e mssql
Update: You can check the progress here

@zroubalik zroubalik merged commit ef7f715 into kedacore:main Jul 21, 2025
24 checks passed
@rickbrouwer rickbrouwer deleted the mssql-refactor branch July 21, 2025 17:22
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
@rickbrouwer @zroubalik @dpochopsky
Refactor MSSQL scaler (kedacore#6714)
9e67935 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
@rickbrouwer @zroubalik
Refactor MSSQL scaler (kedacore#6714)
929f0b9 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
@rickbrouwer @zroubalik @tangobango5
Refactor MSSQL scaler (kedacore#6714)
c96cd5c 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

+1 more reviewer

@SpiritZhou SpiritZhou SpiritZhou left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickbrouwer @SpiritZhou @zroubalik @JorTurFer