Skip to content

Selenium Grid: Trigger param enableManagedDownloads set as true by default#6684

Merged
JorTurFer merged 1 commit intokedacore:mainfrom
NDViet:main
Apr 6, 2025
Merged

Selenium Grid: Trigger param enableManagedDownloads set as true by default#6684
JorTurFer merged 1 commit intokedacore:mainfrom
NDViet:main

Conversation

@VietND96
Copy link
Contributor

@VietND96 VietND96 commented Apr 3, 2025

  • When enableManagedDownloads is true, it works for both cases it enabled (env var SE_NODE_ENABLE_MANAGED_DOWNLOADS=true is set) and it disabled.
  • To avoid confusion for people who enabled this in Node but might miss this config in trigger param, so switch it to true by default.

Checklist

Fixes #

Relates to #

@VietND96 VietND96 requested a review from a team as a code owner April 3, 2025 22:26
…default

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Apr 6, 2025

/run-e2e selenium
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Apr 6, 2025
40 tasks
@JorTurFer JorTurFer merged commit 0375467 into kedacore:main Apr 6, 2025
20 of 21 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Apr 9, 2025
…default (kedacore#6684)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
…default (kedacore#6684)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
…default (kedacore#6684)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
…default (kedacore#6684)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
…default (kedacore#6684)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants