Skip to content

fix call log.Error with nil value error#6662

Merged
JorTurFer merged 1 commit intokedacore:mainfrom
alingse:patch-1
Mar 30, 2025
Merged

fix call log.Error with nil value error#6662
JorTurFer merged 1 commit intokedacore:mainfrom
alingse:patch-1

Conversation

@alingse
Copy link
Contributor

@alingse alingse commented Mar 30, 2025

use correct err for log.Error

and the code should be

		log.Error(errscaledjob, "Unable to write to metrics to Prometheus Server", "labels", labels)

but I'm not sure.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

Signed-off-by: alingse <alingse@foxmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! Thanks

@JorTurFer
Copy link
Member

JorTurFer commented Mar 30, 2025

/run-e2e metrics
Update: You can check the progress here

@JorTurFer JorTurFer merged commit c2d4c44 into kedacore:main Mar 30, 2025
22 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Apr 9, 2025
Signed-off-by: alingse <alingse@foxmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
Signed-off-by: alingse <alingse@foxmail.com>
Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
Signed-off-by: alingse <alingse@foxmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
Signed-off-by: alingse <alingse@foxmail.com>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
Signed-off-by: alingse <alingse@foxmail.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants