Selenium Grid: Add trigger param for Node enables managed downloads capability by VietND96 · Pull Request #6570 · kedacore/keda

VietND96 · 2025-02-25T06:17:18Z

Provide a description of what has been changed

For which Node enables managed downloads capability (via CLI --enable-managed-downloads) with capability name se: downloadsEnabled, it will be counted into the DefaultSlotMatcher impact the request to be assigned to a Node. That means the scaler needs to consider counting the number of sessions and pending requests for autoscaling to behave correctly.

Trigger param name enableManagedDownloads with input value in bool (true/false)

enableManagedDownloads- Set this for Node enabled to auto manage files downloaded for a given session on the Node. When the client requests enabling this feature, it can only be assigned to the Node that also enabled it. Otherwise, the request will wait until it timed out. (Default: false, Optional).

Details for usage

Selenium Grid scaler trigger metadata with Node `enableManagedDownloads`

kind: Deployment
metadata:
  name: selenium-node-chrome
  labels:
    deploymentName: selenium-node-chrome
spec:
  replicas: 1
  template:
    spec:
      containers:
        - name: selenium-node-chrome
          image: selenium/node-chrome:132.0
          ports:
          - containerPort: 5555
          env:
          - name: SE_NODE_BROWSER_VERSION
            value: '132.0'
          - name: SE_NODE_PLATFORM_NAME
            value: 'Linux'
          # https://www.selenium.dev/documentation/grid/configuration/cli_options/#node
          - name: SE_NODE_ENABLE_MANAGED_DOWNLOADS
            value: "true"

---

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: selenium-grid-scaledobject-chrome-132
  namespace: keda
  labels:
    deploymentName: selenium-node-chrome-132
spec:
  maxReplicaCount: 8
  scaleTargetRef:
    name: selenium-node-chrome-132
  triggers:
    - type: selenium-grid
      metadata:
        url: 'http://selenium-hub:4444/graphql'
        browserName: 'chrome'
        platformName: 'Linux'
        browserVersion: '132.0'
        unsafeSsl: 'true'
        # Scaler trigger param configuration should be aligned with Node stereotype.
        enableManagedDownloads: "true"

The request to trigger this scaler should be

options = ChromeOptions()
options.set_capability('platformName', 'Linux')
options.set_capability('browserVersion', '132.0')
# https://www.selenium.dev/documentation/webdriver/drivers/remote_webdriver/#enable-downloads-in-the-grid
options.enable_downloads = True
driver = webdriver.Remote(options=options, command_executor=SELENIUM_GRID_URL)

Checklist

Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

…apability Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 · 2025-02-25T07:10:11Z

@zroubalik, @JorTurFer, this is the last PR that I would like to include in release 2.17.0. Please consider for the merging.

zroubalik · 2025-02-25T09:04:00Z

/run-e2e selenium
Update: You can check the progress here

… enable Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

zroubalik · 2025-02-27T08:27:14Z

/run-e2e selenium
Update: You can check the progress here

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

JorTurFer · 2025-03-10T21:39:29Z

/run-e2e selenium
Update: You can check the progress here

…apability (kedacore#6570) * Selenium Grid: Add trigger param for Node enables managed downloads capability Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Fix CI and update CHANGELOG Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update trigger param naming Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Node with managedDownloadsEnabled can pick up request without feature enable Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Improve PlatformName comparison by implement enum similar Grid core Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

…apability (kedacore#6570) * Selenium Grid: Add trigger param for Node enables managed downloads capability Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Fix CI and update CHANGELOG Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update trigger param naming Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Node with managedDownloadsEnabled can pick up request without feature enable Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Improve PlatformName comparison by implement enum similar Grid core Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

…apability (kedacore#6570) * Selenium Grid: Add trigger param for Node enables managed downloads capability Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Fix CI and update CHANGELOG Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update trigger param naming Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Node with managedDownloadsEnabled can pick up request without feature enable Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Improve PlatformName comparison by implement enum similar Grid core Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

Selenium Grid: Add trigger param for Node enables managed downloads c…

814e362

…apability Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 requested a review from a team as a code owner February 25, 2025 06:17

Fix CI and update CHANGELOG

48b2520

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 force-pushed the PR-20250225 branch from 4f42f0d to 48b2520 Compare February 25, 2025 06:37

Update trigger param naming

631fa4a

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 mentioned this pull request Feb 25, 2025

Selenium Grid: Add trigger param for Node enables managed downloads capability kedacore/keda-docs#1542

Merged

1 task

wozniakjan mentioned this pull request Feb 25, 2025

Release: 2.17.0 #6502

Closed

40 tasks

zroubalik approved these changes Feb 25, 2025

View reviewed changes

Node with managedDownloadsEnabled can pick up request without feature…

490b979

… enable Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 force-pushed the PR-20250225 branch from 6b9f13b to 490b979 Compare February 26, 2025 19:47

VietND96 added 2 commits March 10, 2025 17:56

Improve PlatformName comparison by implement enum similar Grid core

857160f

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

Merge branch 'main' into PR-20250225

cfb998f

JorTurFer approved these changes Mar 10, 2025

View reviewed changes

JorTurFer merged commit 55cdfd8 into kedacore:main Mar 10, 2025
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium Grid: Add trigger param for Node enables managed downloads capability#6570

Selenium Grid: Add trigger param for Node enables managed downloads capability#6570
JorTurFer merged 6 commits intokedacore:mainfrom
NDViet:PR-20250225

VietND96 commented Feb 25, 2025 •

edited

Loading

Uh oh!

VietND96 commented Feb 25, 2025

Uh oh!

zroubalik commented Feb 25, 2025 •

edited by github-actions bot

Loading

Uh oh!

zroubalik commented Feb 27, 2025 •

edited by github-actions bot

Loading

Uh oh!

JorTurFer commented Mar 10, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

VietND96 commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Selenium Grid scaler trigger metadata with Node enableManagedDownloads

Checklist

Uh oh!

VietND96 commented Feb 25, 2025

Uh oh!

zroubalik commented Feb 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Feb 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Mar 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VietND96 commented Feb 25, 2025 •

edited

Loading

Selenium Grid scaler trigger metadata with Node `enableManagedDownloads`

zroubalik commented Feb 25, 2025 •

edited by github-actions bot

Loading

zroubalik commented Feb 27, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Mar 10, 2025 •

edited by github-actions bot

Loading