Selenium Grid: Add trigger param to set custom capabilities for matching specific Nodes#6536
Merged
zroubalik merged 2 commits intokedacore:mainfrom Feb 11, 2025
Merged
Selenium Grid: Add trigger param to set custom capabilities for matching specific Nodes#6536zroubalik merged 2 commits intokedacore:mainfrom
zroubalik merged 2 commits intokedacore:mainfrom
Conversation
…ing specific Nodes Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
This was referenced Feb 9, 2025
Closed
Member
|
/run-e2e selenium |
JorTurFer
approved these changes
Feb 10, 2025
zroubalik
approved these changes
Feb 11, 2025
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
…ing specific Nodes (kedacore#6536) Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Besides current main capabilities
browserName,browserVersion,platformNameare used for matching Node. Selenium Grid supports setting more custom capabilities for matching specific Nodes https://www.selenium.dev/documentation/grid/configuration/toml_options/#setting-custom-capabilities-for-matching-specific-nodesVia this PR, one more trigger parameter is added with the name
capabilitiesto define a JSON string with custom capabilities for matching specific Nodes. This helps users create more scalers to scale their Nodes with custom capabilities.For example
The request to trigger this scaler should be
Checklist
Fixes #
Relates to #