fix: fix isFallbackEnabled when using scaling modifiers#6521
Merged
zroubalik merged 2 commits intokedacore:mainfrom Feb 7, 2025
Merged
fix: fix isFallbackEnabled when using scaling modifiers#6521zroubalik merged 2 commits intokedacore:mainfrom
zroubalik merged 2 commits intokedacore:mainfrom
Conversation
98d3839 to
96d98ae
Compare
JorTurFer
approved these changes
Feb 3, 2025
Member
JorTurFer
left a comment
There was a problem hiding this comment.
nice catch! 🚀
Thanks a lot for the fix 😄
Member
|
/run-e2e fallback |
zroubalik
approved these changes
Feb 6, 2025
Member
|
@y-rabie could you please update the changelog? |
Signed-off-by: Youssef Rabie <youssef.rabie@procore.com>
aef7d35 to
35f5bc8
Compare
Member
|
/run-e2e fallback |
7 tasks
1 task
1 task
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
Signed-off-by: Youssef Rabie <youssef.rabie@procore.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the behavior when using
ScalingModifiersis that if any of the triggers has a metric type ofAverageValuethen fallback is enabled. Intuitively, this is not accurate. When usingScalingModifiers, we should only care about itsmetricType, no matter whatmetricSpecis passed to the current call ofisFallbackEnabled.Also, this helps with the fact that currently,
doFallbackassumes that the metric type when usingScalingModifiersisAverageValuewithout any kind of checking, which under the current implementation, is not guaranteed to be the case.Checklist