refactor gcp stackdriver scaler by omerap12 · Pull Request #6462 · kedacore/keda

omerap12 · 2025-01-02T15:34:53Z

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #5797

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

zroubalik · 2025-01-02T16:04:44Z

/run-e2e gcp
Update: You can check the progress here

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

wozniakjan

lgtm, thank you!

minor nits below

pkg/scalers/gcp_stackdriver_scaler.go

wozniakjan · 2025-01-06T10:08:13Z

just noticed the imports are not sorted the way linter is configured, can you please run following command? (or address the imports sort manually :))

gci write . --skip-generated -s standard -s default -s prefix(github.com/kedacore/keda)

I will retrigger the e2e tests after that

Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Omer Aplatony <omerap12@gmail.com>

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 · 2025-01-06T13:42:24Z

just noticed the imports are not sorted the way linter is configured, can you please run following command? (or address the imports sort manually :))
gci write . --skip-generated -s standard -s default -s prefix(github.com/kedacore/keda)
I will retrigger the e2e tests after that

done

omerap12 · 2025-01-10T18:36:31Z

Friendly ping :) @zroubalik @wozniakjan

dttung2905 · 2025-01-13T21:42:24Z

/run-e2e gcp
Update: You can check the progress here

wozniakjan · 2025-01-14T07:27:02Z

/run-e2e gcp
Update: You can check the progress here

stale · 2025-03-15T07:44:59Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

wozniakjan · 2025-03-17T08:44:58Z

looks like this breaks the e2e tests

	Execution of tests/scalers/gcp/gcp_stackdriver_workload_identity/gcp_stackdriver_workload_identity_test.go, has failed after "three" attempts

you can check for more logs
https://github.com/kedacore/keda/actions/runs/12762977209/job/35572602940

zroubalik

@omerap12 any update here, please?

omerap12 · 2025-03-27T17:52:03Z

@omerap12 any update here, please?

Yeah, sorry about that. I'll take a look this weekend.

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 · 2025-03-30T14:22:39Z

/run-e2e gcp

JorTurFer · 2025-03-30T14:39:27Z

/run-e2e gcp
Update: You can check the progress here

pkg/scalers/gcp_stackdriver_scaler.go

tests/scalers/gcp/gcp_stackdriver_workload_identity/gcp_stackdriver_workload_identity_test.go

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Omer Aplatony <omerap12@gmail.com>

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 · 2025-03-30T15:42:14Z

Ill squash when approved ( if needed )

JorTurFer · 2025-03-30T16:04:34Z

/run-e2e stackdriver
Update: You can check the progress here

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 · 2025-03-30T16:10:38Z

Can you re run it now? @JorTurFer

zroubalik · 2025-03-31T14:21:01Z

/run-e2e stackdriver
Update: You can check the progress here

omerap12 · 2025-04-03T06:33:29Z

@zroubalik I believe we can merge this now :)

omerap12 · 2025-04-22T14:44:26Z

Friendly ping @zroubalik @JorTurFer

zroubalik · 2025-04-24T16:20:56Z

@omerap12 sorry for the delay :) Thanks!

Signed-off-by: Omer Aplatony <omerap12@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

Signed-off-by: Omer Aplatony <omerap12@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

Signed-off-by: Omer Aplatony <omerap12@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

refactor gcp stackdriver scaler

6314664

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 requested a review from a team as a code owner January 2, 2025 15:34

omerap12 added 2 commits January 5, 2025 17:29

Merge branch 'main' into refactor-gcp-stackdriver-scaler

5879a56

lint

8f1127f

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

wozniakjan approved these changes Jan 6, 2025

View reviewed changes

pkg/scalers/gcp_stackdriver_scaler.go Outdated Show resolved Hide resolved

omerap12 and others added 2 commits January 6, 2025 15:39

optional is redundant with default

9adc070

Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Omer Aplatony <omerap12@gmail.com>

lint

27b69c7

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

stale bot added the stale All issues that are marked as stale due to inactivity label Mar 15, 2025

stale bot removed the stale All issues that are marked as stale due to inactivity label Mar 17, 2025

zroubalik reviewed Mar 26, 2025

View reviewed changes

typo

6f504ca

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

JorTurFer requested changes Mar 30, 2025

View reviewed changes

pkg/scalers/gcp_stackdriver_scaler.go Outdated Show resolved Hide resolved

tests/scalers/gcp/gcp_stackdriver_workload_identity/gcp_stackdriver_workload_identity_test.go Outdated Show resolved Hide resolved

omerap12 and others added 3 commits March 30, 2025 18:31

Update pkg/scalers/gcp_stackdriver_scaler.go

f9b317a

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Omer Aplatony <omerap12@gmail.com>

revert

392b23c

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

projectID to projectId

aedb174

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

JorTurFer approved these changes Mar 30, 2025

View reviewed changes

fixed unit tests

0da5179

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

zroubalik merged commit b7f37a0 into kedacore:main Apr 24, 2025
18 checks passed

dttung2905 mentioned this pull request Jun 9, 2025

Refactor Scalers with new declarative scaler config #5797

Open

58 tasks

Conversation

omerap12 commented Jan 2, 2025

Checklist

Uh oh!

zroubalik commented Jan 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wozniakjan commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerap12 commented Jan 6, 2025

Uh oh!

omerap12 commented Jan 10, 2025

Uh oh!

dttung2905 commented Jan 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Jan 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stale bot commented Mar 15, 2025

Uh oh!

wozniakjan commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

omerap12 commented Mar 27, 2025

Uh oh!

omerap12 commented Mar 30, 2025

Uh oh!

JorTurFer commented Mar 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

omerap12 commented Mar 30, 2025

Uh oh!

JorTurFer commented Mar 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerap12 commented Mar 30, 2025

Uh oh!

zroubalik commented Mar 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerap12 commented Apr 3, 2025

Uh oh!

omerap12 commented Apr 22, 2025

Uh oh!

zroubalik commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zroubalik commented Jan 2, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Jan 6, 2025 •

edited

Loading

dttung2905 commented Jan 13, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Jan 14, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Mar 17, 2025 •

edited

Loading

JorTurFer commented Mar 30, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Mar 30, 2025 •

edited by github-actions bot

Loading

zroubalik commented Mar 31, 2025 •

edited by github-actions bot

Loading