Skip to content

refactor aws_kinesis_stream_scaler#6400

Merged
zroubalik merged 2 commits intokedacore:mainfrom
omerap12:refactor_aws_kineses_stram
Dec 7, 2024
Merged

refactor aws_kinesis_stream_scaler#6400
zroubalik merged 2 commits intokedacore:mainfrom
omerap12:refactor_aws_kineses_stram

Conversation

@omerap12
Copy link
Contributor

@omerap12 omerap12 commented Dec 2, 2024

Refactor aws kinesis stream scaler configuration

Checklist

Fixes #5797

Relates to #

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 requested a review from a team as a code owner December 2, 2024 18:57
@wozniakjan
Copy link
Member

wozniakjan commented Dec 2, 2024

/run-e2e aws_kinesis
Update: You can check the progress here

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan enabled auto-merge (squash) December 2, 2024 19:19
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
auto-merge was automatically disabled December 7, 2024 12:54

Head branch was pushed to by a user without write access

@omerap12
Copy link
Contributor Author

omerap12 commented Dec 7, 2024

@wozniakjan Can you please re-approve? I had to rebase :)

@zroubalik
Copy link
Member

zroubalik commented Dec 7, 2024

/run-e2e aws_kinesis
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) December 7, 2024 13:20
@zroubalik zroubalik merged commit 88ddc39 into kedacore:main Dec 7, 2024
ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Scalers with new declarative scaler config

3 participants