add: enable webhook patching with flag#6396
Merged
JorTurFer merged 3 commits intokedacore:mainfrom Dec 16, 2024
Merged
Conversation
bc4db15 to
5877362
Compare
JorTurFer
reviewed
Dec 2, 2024
Member
|
Nice addition! I think that we should document it also as part of docs (maybe here) and support it in our helm chart (disabling the patching when the webhooks aren't deployed) |
wozniakjan
reviewed
Dec 2, 2024
893fb26 to
ea6aea9
Compare
Member
|
can you please also add a changelog entry? |
ea6aea9 to
8216cf8
Compare
7bb8cec to
4218d66
Compare
Signed-off-by: krishna sindhur <krishnasindhur@gmail.com>
Signed-off-by: krishna sindhur <krishnasindhur@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
4218d66 to
bcbcb6e
Compare
Member
|
/run-e2e internal |
zroubalik
reviewed
Dec 4, 2024
Member
zroubalik
left a comment
There was a problem hiding this comment.
Looking good,
Could you please update docs and helm as well?
JorTurFer
approved these changes
Dec 15, 2024
Member
JorTurFer
left a comment
There was a problem hiding this comment.
This is awesome! Could you open a PR updating docs as well?
Author
here it is @JorTurFer |
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
* add: enable webhook patching with flag Signed-off-by: krishna sindhur <krishnasindhur@gmail.com> * update: should enable/disable only the webhook Signed-off-by: krishna sindhur <krishnasindhur@gmail.com> * changelog: put webhook patching flag to 'New' section Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> --------- Signed-off-by: krishna sindhur <krishnasindhur@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: krishna sindhur <krishnasindhur@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a flag in the operator to the webhook patching
Checklist
Fixes #6184