Aws secretsmanager additions#6381
Merged
JorTurFer merged 56 commits intokedacore:mainfrom Feb 6, 2025
Merged
Conversation
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
Signed-off-by: Nick Richardson <nicholas.richardson@akasa.com>
a4701ef to
23175d8
Compare
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
zroubalik
reviewed
Dec 4, 2024
Member
zroubalik
left a comment
There was a problem hiding this comment.
Looking good, thanks. We should also update docs
mpechner-akasa
added a commit
to mpechner-akasa/keda-docs
that referenced
this pull request
Dec 5, 2024
Doc for issue: kedacore/keda#5940 PR: kedacore/keda#6381 Signed-off-by: michael pechner <mike.pechner@akasa.com>
1 task
Contributor
Author
|
docs. kedacore/keda-docs#1508 |
JorTurFer
reviewed
Dec 15, 2024
Member
JorTurFer
left a comment
There was a problem hiding this comment.
Really nice job! some comments inline
tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go
Outdated
Show resolved
Hide resolved
tests/secret-providers/aws_secretmanager_pod_identity/aws_secretmanager_pod_identity_test.go
Outdated
Show resolved
Hide resolved
36f2dcc to
a6b4067
Compare
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
…-akasa/keda into aws-secretsmanager-additions
…ect. Will remove REMOVETestAwsSecretManagerJSONFormat and change aws_secret_manager_pod_identity.go once I have changed this file as expected. Signed-off-by: michael pechner <mike.pechner@akasa.com>
// Local imports . "github.com/kedacore/keda/v2/tests/helper" Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Member
|
e2e tests are failing because the secret has the same name in both cases. This makes that one case passes and the other one fails because the e2e test is trying to create a secret with the same name and the secret is in deletion process You can't create this secret because a secret with this name is already scheduled for deletionYou need to update the value of |
…e the secret. Instead of tryinfg to further randomize the secretname, just let the code do what it should. Added a poll to wait on the secret to be removed. Hoping 2 minniutes is more than enough. Signed-off-by: michael pechner <mike.pechner@akasa.com>
…e the secret. Instead of trying to further randomize the secretname, just let the code do what it should. Added a poll to wait on the secret to be removed. Should happen within a few seconds. But we are talking AWS. 5 minutes really should be more then enough. Signed-off-by: michael pechner <mike.pechner@akasa.com>
…-akasa/keda into aws-secretsmanager-additions
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
JorTurFer
reviewed
Jan 18, 2025
tests/secret-providers/aws_secretmanager_pod_identity/aws_secretmanager_pod_identity_test.go
Outdated
Show resolved
Hide resolved
made sure we set a new secret name for each run Signed-off-by: michael pechner <mike.pechner@akasa.com>
Signed-off-by: Michael D Pechner - Akasa <mike.pechner@akasa.com>
JorTurFer
reviewed
Feb 3, 2025
Member
JorTurFer
left a comment
There was a problem hiding this comment.
Really great job! 2 small comments inline and we are almost there!
tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go
Outdated
Show resolved
Hide resolved
tests/secret-providers/aws_secretmanager_pod_identity/aws_secretmanager_pod_identity_test.go
Outdated
Show resolved
Hide resolved
Member
|
/run-e2e aws |
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Member
|
/run-e2e aws |
JorTurFer
reviewed
Feb 3, 2025
tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go
Outdated
Show resolved
Hide resolved
tests/secret-providers/aws_secretmanager_pod_identity/aws_secretmanager_pod_identity_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: michael pechner <mike.pechner@akasa.com>
…-akasa/keda into aws-secretsmanager-additions
Member
|
/run-e2e aws |
Member
|
/run-e2e aws |
zroubalik
approved these changes
Feb 6, 2025
Member
|
/run-e2e aws |
JorTurFer
pushed a commit
to kedacore/keda-docs
that referenced
this pull request
Feb 6, 2025
…1508) * Documented adding secretKey parameter to access aws secret manager Doc for issue: kedacore/keda#5940 PR: kedacore/keda#6381 Signed-off-by: michael pechner <mike.pechner@akasa.com> * Added a note to the description for the secretKey parameter and entry to the example for the parameter. Signed-off-by: michael pechner <mike.pechner@akasa.com> --------- Signed-off-by: michael pechner <mike.pechner@akasa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify a secretKey in the awsSecretManager TriggerAuthentication. This will allow parsing of secrets that contain Key/Value pairs (returned in JSON format).
Resubmission of #6031
Provide a description of what has been changed
Checklist
Fixes #5940
Relates to #