Use toolchain to define desired Go version#6378
Conversation
|
I ran |
|
/run-e2e internal |
|
I see the benefits of not limiting the minimum version but only suggesting it in case of 3rd parties using KEDA as dependency, but we also must ensure that the user version to build and ship KEDA is the desired one and (AFAIK), Our current approach is based on generating updated build tools image so the |
I think so, both
it's possible those are not related to the |
wozniakjan
left a comment
There was a problem hiding this comment.
lgtm
should we add a changelog entry? I think it's not necessary.
Follow-up from: kedacore#6305 (comment) Ref: https://go.dev/doc/modules/gomod-ref#go Use toolchain to define the desired Go compiler version to be used. Use `go` directive to show the minimum version it can still compile with. Signed-off-by: Matthias Diester <mddiester@gmail.com>
69bbbd4 to
8bf524d
Compare
|
/run-e2e internal |
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Follow-up from: #6305 (comment)
Ref: https://go.dev/doc/modules/gomod-ref#go
Use toolchain to define the desired Go compiler version to be used.
Use
godirective to show the minimum version it can still compile with.Checklist
Relates to #6305