Skip to content

Refactor New Relic scaler#6326

Merged
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:newrelic
Nov 11, 2024
Merged

Refactor New Relic scaler#6326
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:newrelic

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Nov 9, 2024

  • Refactor the scaler to match the new metadata guidelines.
  • The New Relic test showed that "0" and "1" are also valid values ​​for a boolean, but TypedConfig only accepts "true" and "false". Therefore, in the setConfigValueHelper, the function of typed_config.go has been adjusted for boolean parsing.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner November 9, 2024 13:50
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@wozniakjan
Copy link
Member

wozniakjan commented Nov 11, 2024

/run-e2e newrelic
Update: You can check the progress here

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit 211933e into kedacore:main Nov 11, 2024
@rickbrouwer rickbrouwer deleted the newrelic branch November 11, 2024 13:03
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants