Skip to content

fix: Selenium unit test passes#6246

Merged
wozniakjan merged 1 commit intokedacore:mainfrom
JorTurFer:fix-test
Oct 21, 2024
Merged

fix: Selenium unit test passes#6246
wozniakjan merged 1 commit intokedacore:mainfrom
JorTurFer:fix-test

Conversation

@JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 16, 2024

I merged a PR that doesn't pass the test, IDK how 🤦

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner October 16, 2024 17:51
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 16, 2024

/run-e2e selenium
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2024 17:56
@JorTurFer JorTurFer disabled auto-merge October 16, 2024 18:03
@JorTurFer
Copy link
Member Author

This PR solves the issue as the test has been modified there too -> #6169

@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024

I merged a PR that doesn't pass the test, IDK how

happens to anyone :)
this one however seems to pass and has couple of approvals, I will get this in so other PRs don't get false negatives on unit tests

@wozniakjan wozniakjan merged commit 7e44dc7 into kedacore:main Oct 21, 2024
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
@JorTurFer JorTurFer deleted the fix-test branch December 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants