Skip to content

Refactor Kubernetes workload scaler config#6226

Merged
wozniakjan merged 2 commits intokedacore:mainfrom
rickbrouwer:kubernetes_workload
Oct 21, 2024
Merged

Refactor Kubernetes workload scaler config#6226
wozniakjan merged 2 commits intokedacore:mainfrom
rickbrouwer:kubernetes_workload

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Oct 9, 2024

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 9, 2024 12:16
@rickbrouwer rickbrouwer marked this pull request as draft October 9, 2024 12:16
@rickbrouwer rickbrouwer force-pushed the kubernetes_workload branch 27 times, most recently from 176ef3c to 3151c21 Compare October 10, 2024 06:08
@rickbrouwer rickbrouwer marked this pull request as ready for review October 10, 2024 06:27
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! PTAL @wozniakjan

@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024

/run-e2e kubernetes
Update: You can check the progress here

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit efe4d7c into kedacore:main Oct 21, 2024
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer deleted the kubernetes_workload branch October 21, 2024 12:53
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants