Skip to content

Support username and password for etcd#6199

Merged
wozniakjan merged 2 commits intokedacore:mainfrom
dovics:etcd
Oct 21, 2024
Merged

Support username and password for etcd#6199
wozniakjan merged 2 commits intokedacore:mainfrom
dovics:etcd

Conversation

@dovics
Copy link
Contributor

@dovics dovics commented Sep 30, 2024

Provide a description of what has been changed

  • Refactor the etcd scaler to match the new metadata guidelines.
  • Add Support for Username and Password Authentication

Checklist

Relates to #5797

@dovics dovics requested a review from a team as a code owner September 30, 2024 15:43
@dovics dovics changed the title Refactor etcd scaler metadata Refactor etcd scaler config Sep 30, 2024
@n0rm4l-real
Copy link

Is it possible to add user / password based authentication here?

@dovics
Copy link
Contributor Author

dovics commented Oct 7, 2024

@n0rm4l-real Hi,I added username and password authentication support, can you take a look?

@JorTurFer JorTurFer changed the title Refactor etcd scaler config Support username and password for etcd Oct 16, 2024
@JorTurFer
Copy link
Member

PTAL @wozniakjan

@JorTurFer
Copy link
Member

@dovics , could you open a PR to add the values in docs?

@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024

/run-e2e etcd
Update: You can check the progress here

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Signed-off-by: wangrushen <wrs369@88.com>
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024

/run-e2e etcd
Update: You can check the progress here

@wozniakjan wozniakjan merged commit 1a49f5f into kedacore:main Oct 21, 2024
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
* Refactor etcd scaler metadata

Signed-off-by: wangrushen <wrs369@88.com>

* feat: Add Support for etcd Username and Password Authentication

Signed-off-by: wangrushen <wrs369@88.com>

---------

Signed-off-by: wangrushen <wrs369@88.com>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor etcd scaler metadata

Signed-off-by: wangrushen <wrs369@88.com>

* feat: Add Support for etcd Username and Password Authentication

Signed-off-by: wangrushen <wrs369@88.com>

---------

Signed-off-by: wangrushen <wrs369@88.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* Refactor etcd scaler metadata

Signed-off-by: wangrushen <wrs369@88.com>

* feat: Add Support for etcd Username and Password Authentication

Signed-off-by: wangrushen <wrs369@88.com>

---------

Signed-off-by: wangrushen <wrs369@88.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants