Add AWS region to the AWS Config Cache key by maxbog · Pull Request #6134 · kedacore/keda

maxbog · 2024-09-04T09:37:28Z

The PR adds the AWS region to the key used by the AWS config cache

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6128

zroubalik

The build is broken

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog · 2024-09-18T13:55:14Z

@zroubalik I fixed the build

zroubalik · 2024-09-18T14:00:11Z

/run-e2e aws
Update: You can check the progress here

zroubalik · 2024-09-19T13:34:29Z

/run-e2e aws
Update: You can check the progress here

maxbog · 2024-09-24T11:45:04Z

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

zroubalik · 2024-09-24T18:48:36Z

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

yeah, issue on our side, will rerun once it is fixed

ndlanier · 2024-10-04T21:57:04Z

@zroubalik any updates on the e2e testing?

JorTurFer · 2024-10-06T17:50:41Z

/run-e2e aws
Update: You can check the progress here

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog · 2024-10-09T11:53:49Z

@JorTurFer I rebased the PR
Now the tests failed, but it looks like some random crash, can you please rerun the failing job and the e2e tests?

JorTurFer · 2024-10-16T17:59:39Z

/run-e2e aws
Update: You can check the progress here

JorTurFer

PTAL @kedacore/keda-core-contributors

ndlanier · 2024-10-28T16:11:54Z

Any insight into why it paniced/failed on the amd64 validation?

ndlanier · 2024-10-30T15:38:22Z

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

JorTurFer · 2024-10-30T20:03:35Z

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

I've triggered it again because probably it was a transient error

JorTurFer · 2024-10-30T20:03:55Z

@zroubalik @wozniakjan PTAL

maxbog · 2024-11-07T10:16:21Z

Unit tests are passing now

CHANGELOG.md

Signed-off-by: Maksymilian Boguń <max@bogun.me>

zroubalik · 2024-11-11T19:48:14Z

/run-e2e aws
Update: You can check the progress here

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog · 2024-11-12T09:39:53Z

Can we merge the PR? I'd rather not be stuck in the conflict -> merge -> e2e test -> conflict death spiral ;)

votzest · 2024-11-19T17:21:14Z

it seems e2e tests got stuck again? otherwise can you merge this pr @zroubalik, please?

JorTurFer · 2024-11-23T21:12:02Z

@zroubalik @wozniakjan , PTAL

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog · 2024-11-27T12:45:30Z

@JorTurFer @zroubalik Please take a look at this PR. It's waiting for approval for 3 weeks now. The change is ready, waiting to be merged.

zroubalik · 2024-11-28T11:05:42Z

@maxbog there are some conflicts, please fix them and then I think we can merge this.

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog · 2024-11-28T11:13:37Z

@zroubalik done, no conflicts now

Signed-off-by: Maksymilian Boguń <max@bogun.me>

ndlanier · 2024-12-02T16:40:14Z

Can we force this through, can the e2e testing either be removed or ignored?

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan · 2024-12-04T08:14:03Z

/run-e2e aws
Update: You can check the progress here

* Introduce aws region into the AWS config cache Signed-off-by: Maksymilian Boguń <max@bogun.me> * add CHANGELOG entry Signed-off-by: Maksymilian Boguń <max@bogun.me> * embedded AWS region into Authorization metadata Signed-off-by: Maksymilian Boguń <max@bogun.me> * move the fix to Unreleased version Signed-off-by: Maksymilian Boguń <max@bogun.me> * Fix indentation Signed-off-by: Maksymilian Boguń <max@bogun.me> --------- Signed-off-by: Maksymilian Boguń <max@bogun.me> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>

ndlanier · 2025-01-08T15:33:06Z

Just confirming, was this change included in the 2.16.1 release?

zroubalik · 2025-01-08T15:45:44Z

No, we don't include a new features in the patch releases. This will be included in 2.17.

ndlanier · 2025-01-08T16:00:52Z

I would argue this is a fix and not a feature given that it's being implemented to account for a bug in handling cached credentials when the next target in an aws environment is in a different region.
#6128

Are there any ETA's or target dates for 2.17?

Edit: Just read the roadmap, apologies on the question above haha

* Introduce aws region into the AWS config cache Signed-off-by: Maksymilian Boguń <max@bogun.me> * add CHANGELOG entry Signed-off-by: Maksymilian Boguń <max@bogun.me> * embedded AWS region into Authorization metadata Signed-off-by: Maksymilian Boguń <max@bogun.me> * move the fix to Unreleased version Signed-off-by: Maksymilian Boguń <max@bogun.me> * Fix indentation Signed-off-by: Maksymilian Boguń <max@bogun.me> --------- Signed-off-by: Maksymilian Boguń <max@bogun.me> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>

maxbog requested a review from a team as a code owner September 4, 2024 09:37

maxbog force-pushed the region_in_aws_config_cache branch 4 times, most recently from e025102 to a67350c Compare September 4, 2024 13:49

maxbog force-pushed the region_in_aws_config_cache branch from a67350c to 569eeb9 Compare September 17, 2024 19:55

zroubalik reviewed Sep 18, 2024

View reviewed changes

Introduce aws region into the AWS config cache

99f0588

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog force-pushed the region_in_aws_config_cache branch from 569eeb9 to 8e5b30f Compare September 18, 2024 13:12

add CHANGELOG entry

baa3cc1

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog force-pushed the region_in_aws_config_cache branch from 8e5b30f to baa3cc1 Compare September 18, 2024 13:37

JorTurFer approved these changes Oct 6, 2024

View reviewed changes

Merge branch 'main' into region_in_aws_config_cache

d993e5b

Signed-off-by: Maksymilian Boguń <max@bogun.me>

Merge branch 'main' into region_in_aws_config_cache

653c7b0

JorTurFer approved these changes Oct 16, 2024

View reviewed changes

JorTurFer enabled auto-merge (squash) October 16, 2024 18:00

JorTurFer disabled auto-merge October 30, 2024 20:04

maxbog force-pushed the region_in_aws_config_cache branch from dc06dde to 1e6115b Compare November 7, 2024 10:02

zroubalik reviewed Nov 7, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

maxbog added 2 commits November 7, 2024 22:31

Merge branch 'main' into region_in_aws_config_cache

b27719b

move the fix to Unreleased version

d536acb

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog force-pushed the region_in_aws_config_cache branch from 675b2dd to d536acb Compare November 7, 2024 21:33

Merge branch 'main' into region_in_aws_config_cache

ad773f5

Signed-off-by: Maksymilian Boguń <max@bogun.me>

Merge branch 'main' into region_in_aws_config_cache

046e981

Signed-off-by: Maksymilian Boguń <max@bogun.me>

zroubalik approved these changes Nov 28, 2024

View reviewed changes

Merge branch 'main' into region_in_aws_config_cache

8c69fd5

Signed-off-by: Maksymilian Boguń <max@bogun.me>

Fix indentation

d042219

Signed-off-by: Maksymilian Boguń <max@bogun.me>

maxbog and others added 2 commits December 2, 2024 17:52

Merge branch 'main' into region_in_aws_config_cache

32606c3

Merge branch 'main' into region_in_aws_config_cache

ce0c658

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan enabled auto-merge (squash) December 4, 2024 08:14

wozniakjan merged commit 1eaa34c into kedacore:main Dec 4, 2024

Conversation

maxbog commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

maxbog commented Sep 18, 2024

Uh oh!

zroubalik commented Sep 18, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Sep 19, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxbog commented Sep 24, 2024

Uh oh!

zroubalik commented Sep 24, 2024

Uh oh!

ndlanier commented Oct 4, 2024

Uh oh!

JorTurFer commented Oct 6, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxbog commented Oct 9, 2024

Uh oh!

JorTurFer commented Oct 16, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

ndlanier commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndlanier commented Oct 30, 2024

Uh oh!

JorTurFer commented Oct 30, 2024

Uh oh!

JorTurFer commented Oct 30, 2024

Uh oh!

maxbog commented Nov 7, 2024

Uh oh!

Uh oh!

zroubalik commented Nov 11, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxbog commented Nov 12, 2024

Uh oh!

votzest commented Nov 19, 2024

Uh oh!

JorTurFer commented Nov 23, 2024

Uh oh!

maxbog commented Nov 27, 2024

Uh oh!

zroubalik commented Nov 28, 2024

Uh oh!

maxbog commented Nov 28, 2024

Uh oh!

ndlanier commented Dec 2, 2024

Uh oh!

wozniakjan commented Dec 4, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndlanier commented Jan 8, 2025

Uh oh!

zroubalik commented Jan 8, 2025

Uh oh!

ndlanier commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

maxbog commented Sep 4, 2024 •

edited

Loading

zroubalik commented Sep 18, 2024 •

edited by github-actions bot

Loading

zroubalik commented Sep 19, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Oct 6, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Oct 16, 2024 •

edited by github-actions bot

Loading

ndlanier commented Oct 28, 2024 •

edited

Loading

zroubalik commented Nov 11, 2024 •

edited by github-actions bot

Loading

wozniakjan commented Dec 4, 2024 •

edited by github-actions bot

Loading

ndlanier commented Jan 8, 2025 •

edited

Loading