Skip to content

Refactor Solace scaler config #5856

Merged
zroubalik merged 5 commits intokedacore:mainfrom
SpiritZhou:spiritzhou/solace
Jun 5, 2024
Merged

Refactor Solace scaler config #5856
zroubalik merged 5 commits intokedacore:mainfrom
SpiritZhou:spiritzhou/solace

Conversation

@SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Jun 4, 2024

Refactor Solace scaler config

Checklist

Relates to # #5797

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024

/run-e2e solace
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024

/run-e2e solace
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024

/run-e2e solace
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou marked this pull request as ready for review June 5, 2024 07:08
@SpiritZhou SpiritZhou requested a review from a team as a code owner June 5, 2024 07:08
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 5, 2024

/run-e2e solace
Update: You can check the progress here

@SpiritZhou SpiritZhou requested a review from wozniakjan June 5, 2024 07:14
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work!

@zroubalik zroubalik merged commit fd4fcc3 into kedacore:main Jun 5, 2024
rxg8255 pushed a commit to rxg8255/keda that referenced this pull request Jun 24, 2024
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
uucloud pushed a commit to uucloud/keda that referenced this pull request Jul 11, 2024
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: uucloud <uucloud@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants