Add requireAllDemandsAndIgnoreOthers flag by Nohac · Pull Request #5839 · kedacore/keda

Nohac · 2024-05-30T21:52:42Z

This PR adds an extra option requireAllDemandsAndIgnoreOthers (name tbd) to the azure pipeline scaler which ensures that all demands in the scaler definition is present in the incoming job, while ignoring any other demands the job may have.

This is different from requireAllDemands which requires all demands to be an exact match.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Document the azure pipeline property requireAllDemandsAndIgnoreOthers keda-docs#1496
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5579

semgrep-app · 2024-05-30T21:53:55Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L363 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo.}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L351 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter.}

pkg/scalers/azure_pipelines_scaler.go

semgrep-app · 2024-06-03T08:22:34Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L363 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo.}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L351 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter.}

stale · 2024-08-02T16:34:23Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale · 2024-08-09T16:57:30Z

This issue has been automatically closed due to inactivity.

JorTurFer

Could you fix the DCO check and update the changelog too?

JorTurFer · 2024-09-02T20:57:43Z

/run-e2e pipeline
Update: You can check the progress here

semgrep-app · 2024-09-02T20:57:58Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L363 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo.}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L351 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter.}

stale · 2024-11-07T02:06:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

semgrep-app · 2024-11-07T09:20:50Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L391 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo.}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L379 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter.}

semgrep-app · 2024-12-04T08:53:32Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L391 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L379 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter}

zroubalik

Could you please fix DCO and add ingore for semgrep for the test?

stale · 2025-02-02T17:50:52Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

semgrep-app · 2025-02-02T19:26:30Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L391 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L379 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter}

Nohac · 2025-02-02T19:46:28Z

I've fixed DCO and moved the documentation kedacore/keda-docs#1496 to 2.17
I'm not sure how to disable the 'Semgrep' test..

jan-mrm

About the 'Semgrep' I'd think they want something like those 2 suggestions that I just made here - a comment to ignore the 2 findings

pkg/scalers/azure_pipelines_scaler_test.go

semgrep-app · 2025-02-04T21:03:23Z

Semgrep found 1 context-todo finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L393 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo}

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L381 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter}

zroubalik · 2025-02-06T21:29:55Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2025-02-08T23:21:05Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2025-02-10T20:27:27Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2025-02-10T21:08:58Z

Could you fix DCO please? https://github.com/kedacore/keda/pull/5839/checks?check_run_id=36986822520

I merged the docs by mistake and this PR is left :/

CHANGELOG.md

Signed-off-by: jonas <jonas.rudlang@gmail.com>

JorTurFer · 2025-02-11T08:37:13Z

/run-e2e azure
Update: You can check the progress here

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

jan-mrm reviewed May 31, 2024

View reviewed changes

pkg/scalers/azure_pipelines_scaler.go Outdated Show resolved Hide resolved

stale bot added the stale All issues that are marked as stale due to inactivity label Aug 2, 2024

stale bot closed this Aug 9, 2024

JorTurFer reopened this Sep 2, 2024

stale bot removed the stale All issues that are marked as stale due to inactivity label Sep 2, 2024

JorTurFer reviewed Sep 2, 2024

View reviewed changes

stale bot added the stale All issues that are marked as stale due to inactivity label Nov 7, 2024

Nohac force-pushed the main branch from b3f23ba to 075cb01 Compare November 7, 2024 09:19

stale bot removed the stale All issues that are marked as stale due to inactivity label Nov 7, 2024

Nohac marked this pull request as ready for review November 7, 2024 09:23

Nohac requested a review from a team as a code owner November 7, 2024 09:23

zroubalik reviewed Dec 4, 2024

View reviewed changes

stale bot added the stale All issues that are marked as stale due to inactivity label Feb 2, 2025

Nohac force-pushed the main branch from c14c2a5 to 83fea1d Compare February 2, 2025 19:25

stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 2, 2025

jan-mrm reviewed Feb 4, 2025

View reviewed changes

pkg/scalers/azure_pipelines_scaler_test.go Show resolved Hide resolved

pkg/scalers/azure_pipelines_scaler_test.go Show resolved Hide resolved

Nohac force-pushed the main branch from 83fea1d to c17fe6c Compare February 4, 2025 20:58

Nohac force-pushed the main branch from c17fe6c to 67ab205 Compare February 4, 2025 21:08

JorTurFer approved these changes Feb 10, 2025

View reviewed changes

JorTurFer reviewed Feb 10, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

add requireAllDemandsAndIgnoreOthers flag

c66d26c

Signed-off-by: jonas <jonas.rudlang@gmail.com>

Nohac force-pushed the main branch from a3f6df2 to c66d26c Compare February 11, 2025 08:03

JorTurFer enabled auto-merge (squash) February 11, 2025 08:44

zroubalik approved these changes Feb 11, 2025

View reviewed changes

JorTurFer merged commit a8fb1f8 into kedacore:main Feb 11, 2025
21 checks passed

mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025

Add requireAllDemandsAndIgnoreOthers flag (kedacore#5839)

e4fb881

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

Conversation

Nohac commented May 30, 2024 • edited by JorTurFer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

semgrep-app bot commented May 30, 2024

Uh oh!

Uh oh!

semgrep-app bot commented Jun 3, 2024

Uh oh!

stale bot commented Aug 2, 2024

Uh oh!

stale bot commented Aug 9, 2024

Uh oh!

JorTurFer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JorTurFer commented Sep 2, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

semgrep-app bot commented Sep 2, 2024

Uh oh!

stale bot commented Nov 7, 2024

Uh oh!

semgrep-app bot commented Nov 7, 2024

Uh oh!

semgrep-app bot commented Dec 4, 2024

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

stale bot commented Feb 2, 2025

Uh oh!

semgrep-app bot commented Feb 2, 2025

Uh oh!

Nohac commented Feb 2, 2025

Uh oh!

jan-mrm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

semgrep-app bot commented Feb 4, 2025

Uh oh!

zroubalik commented Feb 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Feb 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Feb 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Feb 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Nohac commented May 30, 2024 •

edited by JorTurFer

Loading

JorTurFer left a comment •

edited

Loading

JorTurFer commented Sep 2, 2024 •

edited by github-actions bot

Loading

zroubalik commented Feb 6, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 8, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 10, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 10, 2025 •

edited

Loading

JorTurFer commented Feb 11, 2025 •

edited by github-actions bot

Loading