Skip to content

Refactor solr scaler config #5818

Merged
zroubalik merged 11 commits intokedacore:mainfrom
SpiritZhou:spiritzhou/solrrefactor
Aug 7, 2024
Merged

Refactor solr scaler config #5818
zroubalik merged 11 commits intokedacore:mainfrom
SpiritZhou:spiritzhou/solrrefactor

Conversation

@SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented May 21, 2024

WIP - Refactor Apache Kafka scaler config using declarative parser from #5676

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #5797

@SpiritZhou
Update
d05a16e 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner May 21, 2024 08:27
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented May 29, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented May 29, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented May 29, 2024 •
edited by github-actions bot
Loading

/run-e2e solr
Update: You can check the progress here

@dttung2905 dttung2905 mentioned this pull request May 29, 2024
Open
58 tasks
@SpiritZhou SpiritZhou requested a review from wozniakjan June 4, 2024 03:17
wozniakjan
wozniakjan approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! couple of suggestions for minor improvements below :)

SpiritZhou and others added 2 commits June 5, 2024 10:10
@SpiritZhou @wozniakjan
Update pkg/scalers/solr_scaler.go
c11a177 
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @wozniakjan
Update pkg/scalers/solr_scaler.go
6803825 
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 5, 2024 •
edited by github-actions bot
Loading

/run-e2e solr
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Jun 24, 2024 •
edited by github-actions bot
Loading

/run-e2e solr
Update: You can check the progress here

zroubalik
zroubalik reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpiritZhou is this still WIP or can we merge this PR?

@SpiritZhou SpiritZhou changed the title WIP: Refactor solr scaler config Refactor solr scaler config Jun 26, 2024
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 26, 2024

@SpiritZhou is this still WIP or can we merge this PR?

we can merge it now. Thanks!

@wozniakjan
Copy link
Member

wozniakjan commented Jul 18, 2024

@SpiritZhou I think you may need to check items in the checklist in order for this to merge. Not sure if the WhiteSource is ignored or the PR should be rebased? @zroubalik

@SpiritZhou
Fix log
3e3e523 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/solrrefactor
85f2f72
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jul 22, 2024

@SpiritZhou I think you may need to check items in the checklist in order for this to merge. Not sure if the WhiteSource is ignored or the PR should be rebased? @zroubalik

Hi @wozniakjan, what do you mean by WhiteSource?

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jul 22, 2024 •
edited by github-actions bot
Loading

/run-e2e solr
Update: You can check the progress here

@wozniakjan
Copy link
Member

wozniakjan commented Jul 22, 2024

Hi @wozniakjan, what do you mean by WhiteSource?

never mind, it was a failing CI job that is no longer triggered/required I think

@zroubalik zroubalik merged commit e137285 into kedacore:main Aug 7, 2024
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
@SpiritZhou @wozniakjan
@zroubalik @JorTurFer
Refactor solr scaler config (kedacore#5818)
c95d0e1 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@SpiritZhou @wozniakjan
@zroubalik @mpechner-akasa
Refactor solr scaler config (kedacore#5818)
55cb719 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SpiritZhou @zroubalik @wozniakjan