Refactor arangodb scaler config#5808
Conversation
wozniakjan
left a comment
There was a problem hiding this comment.
nice, looking rather good! :)
|
/run-e2e arangodb |
There was a problem hiding this comment.
lgtm, well done! :)
I noticed few nits, to make the review easier, I submitted them as a PR to your PR - ptal dttung2905#1
|
ptal @kedacore/keda-contributors, I think this is good to merge |
|
/run-e2e arangodb |
Head branch was pushed to by a user without write access
e3dc492 to
4138241
Compare
|
/run-e2e arangodb |
|
Not too sure why this e2e fails all of the sudden though https://github.com/kedacore/keda/actions/runs/9253331273/job/25452795586 The |
|
looks like #5783 introduced validation on the regex passed to the e2e tests, which seems to be misbehaving now, I'm checking this |
|
@dttung2905 there appears to be a combination of two things
|
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
4138241 to
9e2a271
Compare
|
/run-e2e arangodb |
|
ptal @kedacore/keda-contributors. Please help to merge when you have time 🙏 |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: uucloud <uucloud@qq.com>
Refactor arango scaler config reading with a better way
Checklist
Relates to #5797