Recover dropped commit utility function from pkg/scalers/scaler.go#5314
Merged
zroubalik merged 1 commit intokedacore:mainfrom Dec 28, 2023
Merged
Conversation
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Member
|
/run-e2e internal |
zroubalik
approved these changes
Dec 28, 2023
Member
zroubalik
left a comment
There was a problem hiding this comment.
LGTM
thanks for fixing this!
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: anton.lysina <alysina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
As mentioned in the reply #5228 (comment), I created this PR to recover dropped commits when rebasing. This commit would enable us to take in value of any type and convert to any other type
Checklist
Relates to #5228 and #5037