Conversation
|
Hi @bassrock, thanks for the pull request! I'll take a look into it as soon as I can. From what I saw at the first glance:
s.subspec "UI" do |ss|
ss.dependency "DFImageManager/Core"
ss.source_files = "DFImageManager/Source/UI/**/*.{h,m}" # shared files
ss.ios.source_files = "DFImageManager/Source/UI/iOS/*.{h,m}" # platform specific files
end |
There was a problem hiding this comment.
You can't use mach_absolute_time() like that. It returns time in processing units, not seconds like CACurrentMediaTime(). Conversion between mach_absolute_time() units and seconds is quite complicated.
Anyway, both functions are useful when you need to measure time in terms of nanoseconds, which is not the case here. NSDate looks like a good candidate, but it's rather heavy and this code needs to run on the main thread. I would rather use something that is faster.
There was a problem hiding this comment.
Yea the reasoning here is that CACurrentMediaTime is not available on the watch. Any suggestions for a replacement works.
|
Ok will update the specs in a bit. Also this is branched off of develop. |
|
I think CFAbsoluteTimeGetCurrent works. |
|
CFAbsoluteTimeGetCurrent is ok 👍 Subspec name is still iOSUI |
|
Merging, thanks for your contribution @bassrock 👍 |
|
I've removed entire xcodeproj with framework targets and moved to classic CocoaPod project structure with a single Xcode project. Now there is no need to manage two build configuration at the same time, we rely on a single build configuration, which is podpsec and CocoaPods. |
This seems to work and fix #15, The same approach can also be used to add watchUI classes and OS X UI Classes.