Added support for external etcd to CacheServer#170
Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom Mar 6, 2026
Merged
Conversation
7c809b2 to
0ef3377
Compare
gman0
commented
Mar 5, 2026
| if hasKcpTag { | ||
| switch kcpTag { | ||
| case "release-0.28", "release-0.29", "release-30": | ||
| t.Skip("running external etcd with cache-server is only supported with kcp >=0.31") |
Contributor
Author
There was a problem hiding this comment.
We either do this, or add a feature gate and do #171.
25b6021 to
4e9c0f7
Compare
hack/ci/run-e2e-tests.sh now exports kcp release (KCP_TAG passed from .prow.yaml) as KCP_RELEASE environment variable. This is a semi-temporary solution for checking what kcp version the operator is deploying.
4e9c0f7 to
ae53d1a
Compare
On-behalf-of: @SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
ae53d1a to
a8fff5f
Compare
Contributor
|
/approve I like it. :) |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 89590f17b4e5b52bad6eebccfc664d2591ea5aae |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds etcd configuration to CacheServer spec, making it possible to reference an external etcd cluster.
What Type of PR Is This?
/kind api-change
/kind feature
Related Issue(s)
Fixes #157
Release Notes