-
Notifications
You must be signed in to change notification settings - Fork 20
feature: support variable feature flags in e2e runs #171
Copy link
Copy link
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Feature Description
Currently, all e2e tests run by prow have a hardcoded set of feature gates that are being used for all tests:
kcp-operator/hack/ci/testdata/kustomization.yaml
Lines 8 to 12 in 11ec4bc
| patches: | |
| - patch: |- | |
| - op: add | |
| path: /spec/template/spec/containers/0/args/- | |
| value: --feature-gates=ConfigurationBundle=true |
Testing features that depend on particular kcp version is then not possible.
Proposed Solution
- Define an environment variable
TEST_FEATURE_GATESin relevant places (Makefile, hack/run-e2e-tests.sh).- Default it to the value currently used.
- Put an env var placeholder into hack/ci/testdata/kustomization.yaml instead of the hardcoded value.
- run-e2e-tests.sh will envsubst it
- Define appropriate values in our prow definition.
Alternative Solutions
No response
Want to contribute?
- I would like to work on this issue.
Additional Context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.