Skip to content

feature: support variable feature flags in e2e runs #171

@gman0

Description

@gman0

Feature Description

Currently, all e2e tests run by prow have a hardcoded set of feature gates that are being used for all tests:

patches:
- patch: |-
- op: add
path: /spec/template/spec/containers/0/args/-
value: --feature-gates=ConfigurationBundle=true

Testing features that depend on particular kcp version is then not possible.

Proposed Solution

  • Define an environment variable TEST_FEATURE_GATES in relevant places (Makefile, hack/run-e2e-tests.sh).
    • Default it to the value currently used.
  • Put an env var placeholder into hack/ci/testdata/kustomization.yaml instead of the hardcoded value.
    • run-e2e-tests.sh will envsubst it
  • Define appropriate values in our prow definition.

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions