Skip to content

Fix defaulting LATEST#152

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
ntnn:fix-deploy
Feb 7, 2026
Merged

Fix defaulting LATEST#152
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
ntnn:fix-deploy

Conversation

@ntnn
Copy link
Copy Markdown
Member

@ntnn ntnn commented Feb 7, 2026

Summary

Possible fix for #151

I think the | grep only applies to the echo v0.0.0 before it and not the plumbing commands.
So git describe ... was always getting the tag but with the whitespace around it and the grep -o didn't apply and that's why the comparison with VERSION always failed and the latest tag was never updated.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2026
@ntnn
Copy link
Copy Markdown
Member Author

ntnn commented Feb 7, 2026

/cherry-pick release-0.4

In case that this is the fix.

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Feb 7, 2026

@ntnn: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.4

In case that this is the fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ntnn
Fix defaulting LATEST
bc9e3cc 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@xrstf
Copy link
Copy Markdown
Contributor

xrstf commented Feb 7, 2026

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Feb 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Feb 7, 2026

LGTM label has been added.

DetailsGit tree hash: 6ef0753ad8588928054628d0a3a5cd6b0c22e732

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2026
@kcp-ci-bot kcp-ci-bot merged commit 4699b9f into kcp-dev:main Feb 7, 2026
6 checks passed
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Feb 7, 2026

@ntnn: new pull request created: #153

Details

In response to this:

/cherry-pick release-0.4

In case that this is the fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot mentioned this pull request Feb 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@xrstf xrstf

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntnn @kcp-ci-bot @xrstf