fix templating variables for related resources#91
Merged
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
LGTM label has been added. DetailsGit tree hash: af5669710c9e3a88d6f2cd850b46f62fa71ce49b |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest dear bot, please merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I made a simple mistake when writing this function and never caught it because none of the tests checked that side-related information (i.e. the cluster name or the workspace path) are actually available.
Since the cluster name is dynamic, the best I could come up with is relying on its length, which we always know :)
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #90
Release Notes