Remove 1 APIExport = 1 API group limitation#52
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 7f52b6a0e72dd0b2fba897edb758aa60ff0c5d91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When I begun workin with kcp, I was under the impression that an APIExport's name is always the API group for all resources it provides. That wasn't and isn't true though and you can easily have an APIExport named "foo" that contains "cronjobs.bar" and "databases.muh".
This PR cleans up the codebase a bit to remove any hints that the APIExport dictates the API groups.
Since the API group is now free, I added an option to also project it (i.e. rename foo.com to bar.com when transferring the CRDs).
Fixes #47.
What Type of PR Is This?
/kind feature
Release Notes