Skip to content

bump golang to 1.25.7#135

Merged
kcp-ci-bot merged 2 commits into
kcp-dev:mainfrom
gman0:bump-go-1.25.7
Mar 3, 2026
Merged

bump golang to 1.25.7#135
kcp-ci-bot merged 2 commits into
kcp-dev:mainfrom
gman0:bump-go-1.25.7

Conversation

@gman0

@gman0 gman0 commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Version bumps:

  • golang: 1.24.11 to 1.25.7
  • golang-ci-lint: 2.1.6 to 2.10.1 (go 1.25 is supported only since golang-ci-lint 2.4, see changelog)

What Type of PR Is This?

/kind bug

Related Issue(s)

Part of #134

Release Notes

Updated build tools to golang 1.25.7

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2026
@gman0

gman0 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

go mod tidy was clean

@gman0 gman0 marked this pull request as draft March 3, 2026 08:07
@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2026
@gman0 gman0 marked this pull request as ready for review March 3, 2026 08:42
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2026
@gman0

gman0 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

/retest

gman0 added 2 commits March 3, 2026 13:43
@gman0
bump golang to 1.25.7
95d151a 
On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Makefile: bumped golangci-lint to 2.10.1
90aab9a
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 3, 2026
@gman0

gman0 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

/retest

pull-api-syncagent-test-e2e-kcp-0.28

=== RUN   TestAPIExportEndpointSliceSameCluster
    apiexportendpointslice_test.go:57: Creating workspace endpointslice-same-cluster…
    apiexportendpointslice_test.go:57: Creating workspace team-1…
    apiexportendpointslice_test.go:57: Creating workspace team-2…
    apiexportendpointslice_test.go:57: Creating APIExport "kcp.example.com"…
    apiexportendpointslice_test.go:57: Creating APIExportEndpointSlice "kcp.example.com"…
    apiexportendpointslice_test.go:57: Creating APIBinding "kcp.example.com"…
    apiexportendpointslice_test.go:57: Creating APIBinding "kcp.example.com"…
    apiexportendpointslice_test.go:65: Publishing CRDs…
    apiexportendpointslice_test.go:107: Creating APIExportEndpointSlice "dummy"…
    apiexportendpointslice_test.go:113: Running agent "bob"…
    apiexportendpointslice_test.go:119: Waiting for API kcp.example.com/crontabs to be bound in kcp…
    apiexportendpointslice_test.go:134: Creating CronTab in kcp…
    apiexportendpointslice_test.go:147: Failed to create CronTab in kcp: no matches for kind "CronTab" in version "kcp.example.com/v1"
--- FAIL: TestAPIExportEndpointSliceSameCluster (35.02s)

https://public-prow.kcp.k8c.io/view/s3/prow-public-data/pr-logs/pull/kcp-dev_api-syncagent/135/pull-api-syncagent-test-e2e-kcp-0.28/2028813481737719808

ntnn
ntnn approved these changes Mar 3, 2026
View reviewed changes

@ntnn ntnn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@kcp-ci-bot

kcp-ci-bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f82574702d8fd4a39bdf3cf4f7f5b0b060dad99c

@ntnn

ntnn commented Mar 3, 2026

Copy link
Copy Markdown
Member

/assign @xrstf

@xrstf

xrstf commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

/label tide/merge-method-squash
/approve

@kcp-ci-bot

kcp-ci-bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@xrstf: The label(s) /label tide/merge-method-squash cannot be applied. These labels are supported: blocked by backend, merge-type/merge, merge-type/rebase, needs details, service accounts, Epic, design, feature, proposal, ready-to-challenge, redesign. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label tide/merge-method-squash
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot

kcp-ci-bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@xrstf xrstf added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 3, 2026
@kcp-ci-bot kcp-ci-bot merged commit e6f5d25 into kcp-dev:main Mar 3, 2026
11 checks passed
@gman0 gman0 deleted the bump-go-1.25.7 branch March 3, 2026 14:30
@gman0 gman0 mentioned this pull request Mar 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntnn ntnn ntnn approved these changes

Assignees

@xrstf xrstf

@ntnn ntnn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gman0 @kcp-ci-bot @ntnn @xrstf