Enforce common_system dependency and add runtime metrics#92
Merged
Conversation
- Add fatal error when common_system is not available - Ensure IExecutor interface compatibility - Update dependency detection logic - Align with unified build system requirements
- Add ThreadPoolMetrics class for performance tracking - Track job submission, completion, and rejection rates - Measure queue depth and worker utilization - Provide reset functionality for metrics - Enable monitoring system integration
- Add metrics() accessor and reset_metrics() to ThreadPool - Track job execution in workers - Update queue depth on job submission - Record completion and rejection events - Maintain backward compatibility
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
1 similar comment
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Nov 20, 2025
Add step to clone common_system repository before CMake configuration. This is required because PR #92 enforces common_system as a mandatory dependency for ThreadSystem. Without this step, the CMake configuration fails with: "common_system not found - set COMMON_SYSTEM_DIR or add as dependency." Follows the same pattern used in ci.yml workflow. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
ThreadSystem now requires common_system as a mandatory dependency (as enforced in CMakeLists.txt:41-43). Update static-analysis.yml to set BUILD_WITH_COMMON_SYSTEM=ON instead of OFF to align with this requirement and fix the Clang-Tidy Analysis workflow failure. Resolves the CMake configuration error: "ThreadSystem now requires common_system. Set BUILD_WITH_COMMON_SYSTEM=ON."
Add step to clone common_system repository before CMake configuration. This is required because PR #92 enforces common_system as a mandatory dependency for ThreadSystem. Without this step, the CMake configuration fails with: "common_system not found - set COMMON_SYSTEM_DIR or add as dependency." Follows the same pattern used in ci.yml workflow.
1be6401 to
6fd0007
Compare
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Nov 21, 2025
* feat: enforce common_system as required dependency - Add fatal error when common_system is not available - Ensure IExecutor interface compatibility - Update dependency detection logic - Align with unified build system requirements * feat: add thread pool runtime metrics - Add ThreadPoolMetrics class for performance tracking - Track job submission, completion, and rejection rates - Measure queue depth and worker utilization - Provide reset functionality for metrics - Enable monitoring system integration * feat: integrate metrics into thread pool and workers - Add metrics() accessor and reset_metrics() to ThreadPool - Track job execution in workers - Update queue depth on job submission - Record completion and rejection events - Maintain backward compatibility * fix: enable common_system in static-analysis workflow ThreadSystem now requires common_system as a mandatory dependency (as enforced in CMakeLists.txt:41-43). Update static-analysis.yml to set BUILD_WITH_COMMON_SYSTEM=ON instead of OFF to align with this requirement and fix the Clang-Tidy Analysis workflow failure. Resolves the CMake configuration error: "ThreadSystem now requires common_system. Set BUILD_WITH_COMMON_SYSTEM=ON." * fix: add common_system checkout in static-analysis workflow Add step to clone common_system repository before CMake configuration. This is required because PR #92 enforces common_system as a mandatory dependency for ThreadSystem. Without this step, the CMake configuration fails with: "common_system not found - set COMMON_SYSTEM_DIR or add as dependency." Follows the same pattern used in ci.yml workflow.
4 tasks
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* feat: enforce common_system as required dependency - Add fatal error when common_system is not available - Ensure IExecutor interface compatibility - Update dependency detection logic - Align with unified build system requirements * feat: add thread pool runtime metrics - Add ThreadPoolMetrics class for performance tracking - Track job submission, completion, and rejection rates - Measure queue depth and worker utilization - Provide reset functionality for metrics - Enable monitoring system integration * feat: integrate metrics into thread pool and workers - Add metrics() accessor and reset_metrics() to ThreadPool - Track job execution in workers - Update queue depth on job submission - Record completion and rejection events - Maintain backward compatibility * fix: enable common_system in static-analysis workflow ThreadSystem now requires common_system as a mandatory dependency (as enforced in CMakeLists.txt:41-43). Update static-analysis.yml to set BUILD_WITH_COMMON_SYSTEM=ON instead of OFF to align with this requirement and fix the Clang-Tidy Analysis workflow failure. Resolves the CMake configuration error: "ThreadSystem now requires common_system. Set BUILD_WITH_COMMON_SYSTEM=ON." * fix: add common_system checkout in static-analysis workflow Add step to clone common_system repository before CMake configuration. This is required because PR #92 enforces common_system as a mandatory dependency for ThreadSystem. Without this step, the CMake configuration fails with: "common_system not found - set COMMON_SYSTEM_DIR or add as dependency." Follows the same pattern used in ci.yml workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens thread_system's foundation by enforcing common_system dependency and adding comprehensive runtime metrics:
Required Dependency on common_system
Runtime Performance Metrics
Changes
Build System
Metrics Infrastructure
ThreadPoolMetricsclass with atomic countersThread Pool Integration
metrics()accessor to ThreadPoolAPI Changes
New Public Methods
Breaking Changes
Testing
Migration Guide
For standalone builds:
Performance Impact