refactor(queue): fix misleading lockfree_queue naming#370
Merged
Conversation
- Create concurrent/ directory for fine-grained locking implementations - Move concurrent_queue implementation to concurrent/concurrent_queue.h - Update lockfree_queue.h as backward compatibility header - Improve deprecation messages with "MISLEADING NAME" warning - Update lockfree_queue alias to reference true lock-free alternative - Update tests to use new include path and detail:: namespace This change implements Phase 2-3 of issue #359 to fix misleading lockfree_queue naming that violates Kent Beck's "Reveals Intention" principle.
- Update API_REFERENCE.md with new concurrent/ directory path - Update API_REFERENCE_KO.md with new header location - Add issue #359 entries to CHANGELOG.md and CHANGELOG_KO.md - Document detail:: namespace and migration guidance
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(queue): move concurrent_queue to dedicated directory - Create concurrent/ directory for fine-grained locking implementations - Move concurrent_queue implementation to concurrent/concurrent_queue.h - Update lockfree_queue.h as backward compatibility header - Improve deprecation messages with "MISLEADING NAME" warning - Update lockfree_queue alias to reference true lock-free alternative - Update tests to use new include path and detail:: namespace This change implements Phase 2-3 of issue #359 to fix misleading lockfree_queue naming that violates Kent Beck's "Reveals Intention" principle. * docs: update API references for concurrent_queue location change - Update API_REFERENCE.md with new concurrent/ directory path - Update API_REFERENCE_KO.md with new header location - Add issue #359 entries to CHANGELOG.md and CHANGELOG_KO.md - Document detail:: namespace and migration guidance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #359 - Fix misleading
lockfree_queuenaming that violates Kent Beck's "Reveals Intention" principle.concurrent/directory for fine-grained locking implementationsconcurrent_queueimplementation to new locationlockfree/lockfree_queue.hto backward compatibility headerdetail::namespaceChanges
Code Changes
include/kcenon/thread/concurrent/concurrent_queue.h- Main implementation locationinclude/kcenon/thread/lockfree/lockfree_queue.h- Now a backward compatibility headerinclude/kcenon/thread/forward.h- Updated deprecation messagetests/unit/lockfree_test/lockfree_queue_test.cpp- Use new include pathDocumentation Changes
docs/API_REFERENCE.md- Updated header path and namespacedocs/API_REFERENCE_KO.md- Updated header path and namespacedocs/CHANGELOG.md- Added issue [REFACTOR] Fix misleading lockfree_queue naming - Kent Beck Reveals Intention #359 entrydocs/CHANGELOG_KO.md- Added issue [REFACTOR] Fix misleading lockfree_queue naming - Kent Beck Reveals Intention #359 entryTest Plan
Migration Guide
Closes #359