docs(adr): add ADR-002 for typed_pool evaluation - resolves #354#357
Merged
Conversation
Analysis and decision regarding Issue #354: - Evaluated typed_pool template hierarchy for Simple Design compliance - Decision: Keep typed_pool with improved documentation (Option A) Rationale: - typed_pool provides priority-based scheduling, distinct from thread_pool - No significant code duplication between hierarchies - Template-based priorities offer compile-time type safety - Active usage in tests, examples, and benchmarks Documentation updates: - Add "Choosing Between Thread Pools" comparison section - Document when to use each implementation - Add feature comparison table Resolves #354
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
Analysis and decision regarding Issue #354: - Evaluated typed_pool template hierarchy for Simple Design compliance - Decision: Keep typed_pool with improved documentation (Option A) Rationale: - typed_pool provides priority-based scheduling, distinct from thread_pool - No significant code duplication between hierarchies - Template-based priorities offer compile-time type safety - Active usage in tests, examples, and benchmarks Documentation updates: - Add "Choosing Between Thread Pools" comparison section - Document when to use each implementation - Add feature comparison table Resolves #354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis Findings
typed_pool Provides Distinct Value
Decision Rationale
Changes
docs/adr/ADR-002-typed-pool-evaluation.md: New ADR documenting the analysis and decisiondocs/FEATURES.md: Add "Choosing Between Thread Pools" comparison sectiondocs/FEATURES_KO.md: Korean translation of the comparison sectionTest plan
Closes #354