refactor(vcpkg): standardize vcpkg.json following ecosystem conventions#350
Merged
Conversation
- Rename package from thread-system to kcenon-thread-system - Fix license field to match LICENSE file (BSD-3-Clause) - Remove invalid builtin-baseline field - Add $schema for manifest validation - Add port-version field (0) - Add supports field excluding uwp and xbox platforms - Add kcenon-common-system as ecosystem dependency - Update gtest dependency to include gmock feature Fixes #348
- Document kcenon-thread-system package name - Add vcpkg.json dependency example - Document optional features (testing, logging, development)
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (52.65%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 60.12% 52.65% -7.47%
==========================================
Files 24 25 +1
Lines 1319 1504 +185
==========================================
- Hits 793 792 -1
- Misses 526 712 +186 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Separate baseline configuration from vcpkg.json following vcpkg best practices. This allows vcpkg.json to focus on package metadata while baseline and registry settings are managed in the configuration file.
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
…ready The kcenon-common-system package is not yet available in the vcpkg registry. This dependency will be added once the kcenon vcpkg registry is established (blocked by kcenon/common_system#252). Update README to clarify common_system requirement for vcpkg users.
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…ns (#350) * refactor(vcpkg): standardize vcpkg.json following ecosystem conventions - Rename package from thread-system to kcenon-thread-system - Fix license field to match LICENSE file (BSD-3-Clause) - Remove invalid builtin-baseline field - Add $schema for manifest validation - Add port-version field (0) - Add supports field excluding uwp and xbox platforms - Add kcenon-common-system as ecosystem dependency - Update gtest dependency to include gmock feature Fixes #348 * docs: add vcpkg integration guide to README - Document kcenon-thread-system package name - Add vcpkg.json dependency example - Document optional features (testing, logging, development) * build(vcpkg): add vcpkg-configuration.json for baseline management Separate baseline configuration from vcpkg.json following vcpkg best practices. This allows vcpkg.json to focus on package metadata while baseline and registry settings are managed in the configuration file. * fix(vcpkg): remove kcenon-common-system dependency until registry is ready The kcenon-common-system package is not yet available in the vcpkg registry. This dependency will be added once the kcenon vcpkg registry is established (blocked by kcenon/common_system#252). Update README to clarify common_system requirement for vcpkg users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thread-systemtokcenon-thread-systemkcenon-common-systemas ecosystem dependencyChanges
vcpkg.json
thread-system→kcenon-thread-systemMIT→BSD-3-Clause(matches LICENSE file)builtin-baselinefield (invalid)$schemafor manifest validationport-versionfield (0)supportsfield excluding uwp and xbox platformskcenon-common-systemas ecosystem dependencyREADME.md
Test Plan
Related Issues
Fixes #348