refactor(config): adopt unified KCENON_* feature flags#334
Merged
Conversation
- Replace THREAD_HAS_COMMON_EXECUTOR/RESULT/CONCEPTS with KCENON_HAS_* equivalents - Include feature_flags.h from common_system (guarded with __has_include) - Remove local __has_include based macro definitions in thread pool headers - Add KCENON_* as primary macros in CMake definitions - Keep THREAD_HAS_* as legacy aliases for backward compatibility - Update #ifdef to #if for consistent macro usage pattern Relates to: kcenon/common_system#223, kcenon/common_system#224 Closes #333
- Add issue #333 changes to CHANGELOG and CHANGELOG_KO - Update BUILD_GUIDE to reference KCENON_HAS_COMMON_CONCEPTS as primary macro - Note legacy THREAD_HAS_* macros as backward compatible aliases
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
…implementations The common_system ILogger interface removed the deprecated log(level, message, file, line, function) method. Update example logger implementations to use log(const log_entry&) directly. - Remove 5-parameter log override from console_logger - Remove 5-parameter log override from mock_logger - Update log(log_entry) to handle output directly
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(config): adopt unified KCENON_* feature flags - Replace THREAD_HAS_COMMON_EXECUTOR/RESULT/CONCEPTS with KCENON_HAS_* equivalents - Include feature_flags.h from common_system (guarded with __has_include) - Remove local __has_include based macro definitions in thread pool headers - Add KCENON_* as primary macros in CMake definitions - Keep THREAD_HAS_* as legacy aliases for backward compatibility - Update #ifdef to #if for consistent macro usage pattern Relates to: kcenon/common_system#223, kcenon/common_system#224 Closes #333 * docs: update documentation for KCENON_* feature flags adoption - Add issue #333 changes to CHANGELOG and CHANGELOG_KO - Update BUILD_GUIDE to reference KCENON_HAS_COMMON_CONCEPTS as primary macro - Note legacy THREAD_HAS_* macros as backward compatible aliases * fix(examples): remove deprecated 5-parameter log method from ILogger implementations The common_system ILogger interface removed the deprecated log(level, message, file, line, function) method. Update example logger implementations to use log(const log_entry&) directly. - Remove 5-parameter log override from console_logger - Remove 5-parameter log override from mock_logger - Update log(log_entry) to handle output directly * docs: add changelog entry for deprecated ILogger method removal fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THREAD_HAS_*macros with unifiedKCENON_HAS_*equivalentsfeature_flags.hfrom common_system (guarded with__has_include)__has_includebased macro definitions in thread pool headersChanges
CMake
ThreadSystemDependencies.cmake: DefineKCENON_HAS_COMMON_EXECUTORandKCENON_HAS_COMMON_RESULT(primary), withTHREAD_HAS_*as legacy aliasesThreadSystemFeatures.cmake: DefineKCENON_HAS_COMMON_CONCEPTS(primary), withTHREAD_HAS_COMMON_CONCEPTSas legacy aliasHeaders
thread_pool.h: Includefeature_flags.h(guarded), useKCENON_HAS_COMMON_EXECUTORtyped_thread_pool.h: Includefeature_flags.h(guarded), useKCENON_HAS_COMMON_EXECUTORSource
thread_pool.cpp: UseKCENON_HAS_COMMON_EXECUTORtyped_thread_pool.cpp: UseKCENON_HAS_COMMON_EXECUTORDocumentation
Related Issues
Test plan
Closes #333