refactor: migrate from deprecated common_system APIs#332
Merged
Conversation
Remove deprecated THREAD_LOG_TRACE, THREAD_LOG_DEBUG, THREAD_LOG_INFO, THREAD_LOG_WARN, and THREAD_LOG_ERROR macros from thread_logger.h. These macros were defined but never used in the codebase. As part of the common_system API migration (#331), removing these avoids any potential confusion with the standard LOG_* macros. Addresses #331
Add pragma directives to suppress deprecation warnings for the legacy log(level, message, file, line, function) method implementation in logger_system_adapter. This method is required as it overrides a pure virtual function in ILogger interface. The suppression is necessary during the migration period until common_system v3.0.0 removes the deprecated method. Documentation added clarifying removal timeline. Addresses #331
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(logger): remove unused THREAD_LOG_* macros Remove deprecated THREAD_LOG_TRACE, THREAD_LOG_DEBUG, THREAD_LOG_INFO, THREAD_LOG_WARN, and THREAD_LOG_ERROR macros from thread_logger.h. These macros were defined but never used in the codebase. As part of the common_system API migration (#331), removing these avoids any potential confusion with the standard LOG_* macros. Addresses #331 * refactor(adapter): add deprecation warning suppression for legacy API Add pragma directives to suppress deprecation warnings for the legacy log(level, message, file, line, function) method implementation in logger_system_adapter. This method is required as it overrides a pure virtual function in ILogger interface. The suppression is necessary during the migration period until common_system v3.0.0 removes the deprecated method. Documentation added clarifying removal timeline. Addresses #331 * docs: update CHANGELOG with deprecation migration changes Add entries for issue #331: - Document removal of THREAD_LOG_* macros from thread_logger.h - Document deprecation warning suppression in logger_system_adapter Updated both English and Korean versions. Addresses #331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR addresses the deprecation migration tracked in #331. The changes prepare thread_system for common_system v3.0.0 which will remove deprecated APIs.
THREAD_LOG_* Macros Removal
The following macros were removed from
thread_logger.h:These macros were defined but never used in the codebase, and could cause confusion with the standard LOG_* macros from common_system.
Legacy Logger Method Handling
The
log(level, message, file, line, function)method inlogger_system_adapter.his an override of a deprecated pure virtual function in ILogger interface. Since the base method is still required (pure virtual), we suppress deprecation warnings with appropriate pragmas. This implementation will be removed when common_system v3.0.0 removes the deprecated base method.Test Plan
-Wdeprecated-declarationsflagCloses #331