feat(monitoring): migrate to common::interfaces::IMonitor (#312)#323
Merged
kcenon merged 2 commits intoDec 19, 2025
Merged
Conversation
Replace deprecated thread_system monitoring interfaces with common_system's IMonitor interface. Changes: - Remove monitoring_interface.h, monitorable_interface.h - Remove common_system_monitoring_adapter.h (no longer needed) - Update thread_context.h to use common::interfaces::IMonitor - Update thread_pool.cpp to use common::interfaces types - Update thread_worker.cpp to use common::interfaces types - Update tests and examples to use new API The thread_context now translates thread pool metrics to individual IMonitor::record_metric() calls with tags for component identification. Closes #312
Add documentation for Issue #312 - Phase 3 changes: - Document removed monitoring_interface.h and related headers - Document thread_context migration to common::interfaces::IMonitor - Update both English and Korean CHANGELOG files
Contributor
📊 Performance Benchmark ResultsPerformance Benchmark ReportNo benchmark data available. ℹ️ No baseline reference availableThis is the first benchmark run or baseline file is missing. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* feat(monitoring): migrate to common::interfaces::IMonitor Replace deprecated thread_system monitoring interfaces with common_system's IMonitor interface. Changes: - Remove monitoring_interface.h, monitorable_interface.h - Remove common_system_monitoring_adapter.h (no longer needed) - Update thread_context.h to use common::interfaces::IMonitor - Update thread_pool.cpp to use common::interfaces types - Update thread_worker.cpp to use common::interfaces types - Update tests and examples to use new API The thread_context now translates thread pool metrics to individual IMonitor::record_metric() calls with tags for component identification. Closes #312 * docs: update CHANGELOG for monitoring interface migration Add documentation for Issue #312 - Phase 3 changes: - Document removed monitoring_interface.h and related headers - Document thread_context migration to common::interfaces::IMonitor - Update both English and Korean CHANGELOG files
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitoring_interface.h,monitorable_interface.h, andcommon_system_monitoring_adapter.hthread_contextto usecommon::interfaces::IMonitorfor metrics recordingChanges
Breaking Changes
kcenon::thread::monitoring_interface::monitoring_interfaceremovedkcenon::thread::monitorable_interfaceremovedcommon::interfaces::IMonitorimplementationsAPI Migration
monitoring_interface::monitoring_interfacecommon::interfaces::IMonitormonitoring_interface::thread_pool_metricscommon::interfaces::thread_pool_metricsmonitoring_interface::worker_metricscommon::interfaces::worker_metricsmonitoring_interface::system_metricscommon::interfaces::system_metricsupdate_*_metrics(metrics)record_metric(name, value, tags)New Monitoring Pattern
The
thread_contextnow translates structured metrics to individualrecord_metric()calls with tags:Test plan
Closes #312