Replace PACS_WITH_COMMON_SYSTEM with KCENON_HAS_COMMON_SYSTEM#402
Merged
Conversation
…MON_SYSTEM Replace the project-specific macro PACS_WITH_COMMON_SYSTEM with the unified KCENON_HAS_COMMON_SYSTEM macro for consistent feature flag naming across the kcenon ecosystem. Changes: - Update header files (dicom_session.hpp, network_adapter.hpp, ai_service_connector.hpp) to use KCENON_HAS_COMMON_SYSTEM with default value 0 when not defined - Update source files to use #if KCENON_HAS_COMMON_SYSTEM instead of #ifdef PACS_WITH_COMMON_SYSTEM - Update CMakeLists.txt to define both KCENON_HAS_COMMON_SYSTEM=1 and PACS_WITH_COMMON_SYSTEM=1 for backward compatibility - Add macro default definitions in source files that use the macro The legacy PACS_WITH_COMMON_SYSTEM is kept as an alias during the migration window. Closes #401
…atibility thread_system's thread_pool.h uses conditional compilation for is_running(): - KCENON_HAS_COMMON_EXECUTOR=1: virtual function with 'override' - KCENON_HAS_COMMON_EXECUTOR=0: non-virtual function When thread_system is compiled with common_system, it uses the virtual version. Consumer code must use the same definition to match function signatures and avoid link errors on Windows.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* refactor(macros): replace PACS_WITH_COMMON_SYSTEM with KCENON_HAS_COMMON_SYSTEM Replace the project-specific macro PACS_WITH_COMMON_SYSTEM with the unified KCENON_HAS_COMMON_SYSTEM macro for consistent feature flag naming across the kcenon ecosystem. Changes: - Update header files (dicom_session.hpp, network_adapter.hpp, ai_service_connector.hpp) to use KCENON_HAS_COMMON_SYSTEM with default value 0 when not defined - Update source files to use #if KCENON_HAS_COMMON_SYSTEM instead of #ifdef PACS_WITH_COMMON_SYSTEM - Update CMakeLists.txt to define both KCENON_HAS_COMMON_SYSTEM=1 and PACS_WITH_COMMON_SYSTEM=1 for backward compatibility - Add macro default definitions in source files that use the macro The legacy PACS_WITH_COMMON_SYSTEM is kept as an alias during the migration window. Closes #401 * fix(cmake): add KCENON_HAS_COMMON_EXECUTOR for thread_system ABI compatibility thread_system's thread_pool.h uses conditional compilation for is_running(): - KCENON_HAS_COMMON_EXECUTOR=1: virtual function with 'override' - KCENON_HAS_COMMON_EXECUTOR=0: non-virtual function When thread_system is compiled with common_system, it uses the virtual version. Consumer code must use the same definition to match function signatures and avoid link errors on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PACS_WITH_COMMON_SYSTEMwith unifiedKCENON_HAS_COMMON_SYSTEMmacro#if KCENON_HAS_COMMON_SYSTEMpattern with default value 0PACS_WITH_COMMON_SYSTEMas legacy aliasKCENON_HAS_COMMON_EXECUTOR=1for thread_system ABI compatibilityChanges
Header Files
include/pacs/ai/ai_service_connector.hppinclude/pacs/integration/dicom_session.hppinclude/pacs/integration/network_adapter.hppSource Files
src/ai/ai_result_handler.cppsrc/network/dicom_server.cppsrc/network/v2/dicom_association_handler.cppsrc/network/v2/dicom_server_v2.cppBuild Configuration
CMakeLists.txt:KCENON_HAS_COMMON_SYSTEM=1andPACS_WITH_COMMON_SYSTEM=1when common_system is availableKCENON_HAS_COMMON_EXECUTOR=1for thread_system ABI compatibility (fixes Windows link error)Tests
tests/services/storage_scu_test.cppRelated PRs
Test plan
Closes #401