deprecation(logger): remove deprecated log method with source location#400
Merged
Merged
Conversation
Remove the deprecated log(level, message, file, line, function) method that was marked for removal in v3.0.0. The underlying common_system logger now auto-captures source location, making explicit parameters unnecessary. Changes: - Remove deprecated method declaration from logger_adapter.hpp - Remove deprecated method implementation from logger_adapter.cpp - Update tests to use the recommended log(level, message) API Resolves #399
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
#400) Remove the deprecated log(level, message, file, line, function) method that was marked for removal in v3.0.0. The underlying common_system logger now auto-captures source location, making explicit parameters unnecessary. Changes: - Remove deprecated method declaration from logger_adapter.hpp - Remove deprecated method implementation from logger_adapter.cpp - Update tests to use the recommended log(level, message) API Resolves #399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log(level, message, file, line, function)method fromlogger_adapterlog(level, message)APIChanges
Removed APIs
logger_adapter::log(log_level, const std::string&, const std::string&, int, const std::string&)Migration
Users should use the simpler API:
Test Plan
Related Issues
Resolves #399