chore(cmake): Standardize namespace to snake_case (NetworkSystem:: → network_system::)#853
Merged
Merged
Conversation
…network_system::) Adopt ecosystem convention of <name>:: snake_case namespace. Existing backward compatibility aliases already cover NetworkSystem:: consumers. Closes #852
Contributor
Performance ComparisonBase Branch ResultsNo base results PR Branch ResultsNo PR results |
5 tasks
Contributor
Coverage Report
Coverage DetailsFull HTML report is available as a build artifact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkSystem::tonetwork_system::to adopt ecosystem convention of<package_name>::snake_case namespacenetwork_system_LIBRARIESvariable to reference the newnetwork_system::NetworkSystemtargetNetworkSystem_FOUND,NetworkSystem_LIBRARIES, etc.) remain in place and continue to work for downstream consumers still using the old namespace conventionRelated Issues
What Changed
cmake/NetworkSystemInstall.cmakeNAMESPACE NetworkSystem::→NAMESPACE network_system::ininstall(EXPORT ...)cmake/network_system-config.cmake.innetwork_system_LIBRARIESupdated tonetwork_system::NetworkSystemBackward Compatibility
The config file already provides legacy variable aliases:
These variables continue to resolve correctly under the new namespace.
Test plan
find_package(network_system)resolvesnetwork_system::NetworkSystemtarget${NetworkSystem_LIBRARIES}variable still works for existing consumers