Skip to content

chore(cmake): Standardize namespace to snake_case (NetworkSystem:: → network_system::)#853

Merged
kcenon merged 1 commit into
mainfrom
chore/cmake-snake-case-namespace-852
Mar 17, 2026
Merged

chore(cmake): Standardize namespace to snake_case (NetworkSystem:: → network_system::)#853
kcenon merged 1 commit into
mainfrom
chore/cmake-snake-case-namespace-852

Conversation

@kcenon

@kcenon kcenon commented Mar 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Change CMake export namespace from NetworkSystem:: to network_system:: to adopt ecosystem convention of <package_name>:: snake_case namespace
  • Update the network_system_LIBRARIES variable to reference the new network_system::NetworkSystem target
  • Existing backward compatibility variables (NetworkSystem_FOUND, NetworkSystem_LIBRARIES, etc.) remain in place and continue to work for downstream consumers still using the old namespace convention

Related Issues

What Changed

File Change
cmake/NetworkSystemInstall.cmake NAMESPACE NetworkSystem::NAMESPACE network_system:: in install(EXPORT ...)
cmake/network_system-config.cmake.in network_system_LIBRARIES updated to network_system::NetworkSystem

Backward Compatibility

The config file already provides legacy variable aliases:

set(NetworkSystem_FOUND TRUE)
set(NetworkSystem_LIBRARIES ${network_system_LIBRARIES})
# ... etc.

These variables continue to resolve correctly under the new namespace.

Test plan

  • Verify find_package(network_system) resolves network_system::NetworkSystem target
  • Verify legacy ${NetworkSystem_LIBRARIES} variable still works for existing consumers
  • CI builds pass on all platforms

…network_system::)

Adopt ecosystem convention of <name>:: snake_case namespace.
Existing backward compatibility aliases already cover NetworkSystem:: consumers.

Closes #852
@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison

Base Branch Results

No base results

PR Branch Results

No PR results

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Metric Value
Line Coverage 60.9%
Target 75% (stretch: 80%)
Coverage Details

Full HTML report is available as a build artifact.

@kcenon kcenon merged commit a27e1ec into main Mar 17, 2026
42 checks passed
@kcenon kcenon deleted the chore/cmake-snake-case-namespace-852 branch March 17, 2026 10:53
kcenon added a commit that referenced this pull request Apr 13, 2026
…network_system::) (#853)

Adopt ecosystem convention of <name>:: snake_case namespace.
Existing backward compatibility aliases already cover NetworkSystem:: consumers.

Closes #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cmake): Standardize namespace to snake_case (NetworkSystem:: → network_system::)

1 participant