refactor(headers): expose public types via non-detail paths#681
Merged
Conversation
- Create types/result.h as public API for Result<T> types - Create config/feature_flags.h as public API for feature detection - Update all interface headers to use types/result.h - Update public headers to use config/feature_flags.h - Update network_system.h to use umbrella headers This ensures public API headers don't directly include detail/ paths, improving encapsulation while maintaining backward compatibility. Part of #577
13 tasks
Contributor
Performance ComparisonBase Branch ResultsNo base results PR Branch ResultsNo PR results |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
- Create types/result.h as public API for Result<T> types - Create config/feature_flags.h as public API for feature detection - Update all interface headers to use types/result.h - Update public headers to use config/feature_flags.h - Update network_system.h to use umbrella headers This ensures public API headers don't directly include detail/ paths, improving encapsulation while maintaining backward compatibility. Part of #577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #577
Summary
types/result.has public API forResult<T>typesconfig/feature_flags.has public API for feature detectiontypes/result.hinstead ofdetail/utils/result_types.hconfig/feature_flags.hinstead ofdetail/config/feature_flags.hnetwork_system.hto use umbrella headersWhy This Change
The EPIC #577 goal is to properly encapsulate internal implementation details. Previously, public API headers (interfaces) were directly including
detail/headers, which violates the separation between public API and internal implementation.This PR ensures:
detail/pathsutils.h,config/config.h, etc.) remain the proper entry points for exposing internal typesTest Plan
cmake --build build --config Release)detail/directly