refactor(facade): update websocket_facade to return common protocol interfaces#658
Merged
kcenon merged 1 commit intoFeb 3, 2026
Merged
Conversation
…nterfaces (#657) Modify websocket_facade to return i_protocol_client/i_protocol_server instead of messaging_ws_client/messaging_ws_server types, matching the pattern used by tcp_facade and udp_facade. Changes: - Add ws_client_adapter wrapping messaging_ws_client - Add ws_server_adapter with ws_session_wrapper for session abstraction - Update websocket_facade.h to use common interface return types - Update tests for new interface
4 tasks
Contributor
Performance ComparisonBase Branch ResultsNo base results PR Branch ResultsNo PR results |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…nterfaces (#657) (#658) Modify websocket_facade to return i_protocol_client/i_protocol_server instead of messaging_ws_client/messaging_ws_server types, matching the pattern used by tcp_facade and udp_facade. Changes: - Add ws_client_adapter wrapping messaging_ws_client - Add ws_server_adapter with ws_session_wrapper for session abstraction - Update websocket_facade.h to use common interface return types - Update tests for new interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ws_client_adapterwrappingmessaging_ws_clientto implementi_protocol_clientws_server_adapterwithws_session_wrapperfor session abstraction to implementi_protocol_serverwebsocket_facade.hto returni_protocol_client/i_protocol_serverinstead of WebSocket-specific interfacesThis brings WebSocket facade in line with the unified interface pattern used by
tcp_facadeandudp_facade.Test Plan
Closes #657