What

Apply NETWORK_COVERAGE_TIMEOUT_MULTIPLIER at the 24 explicit wait_for(..., std::chrono::seconds(3)) call sites in tests/unit/http2_client_branch_test.cpp, plus the make_connected_client default request_timeout = std::chrono::milliseconds(2000) parameter. No src/ changes. No new TEST_F. No fixture changes.

Change Type

• Test infrastructure / call-site fix only

Why

PR #1113 (Round 4) introduced the multiplier to the fixture default-arg path but left the explicit-timeout call sites unscaled. Round-5 diagnosis (latest comment on #1112) confirmed ROOT_CAUSE 3 (Excluded call sites still trapping) with high confidence:

• tests/support/hermetic_transport_fixture.h header docstring explicitly states: "Callers passing an explicit timeout should multiply by NETWORK_COVERAGE_TIMEOUT_MULTIPLIER themselves at the call site."
• The 24 dispatcher TEST_F in http2_client_branch_test.cpp all pass an explicit std::chrono::seconds(3) literal -- so the multiplier never applies, and they trap at literal 3s under coverage instrumentation (observed 5.1-5.4s handshake completion in workflow run 25558218320).
• make_connected_client default request_timeout = std::chrono::milliseconds(2000) is also literal, so the http2_client request timeout fires before tests can observe success under coverage.

Result: PR #1113 merged green in Debug/Release but produced 0pp coverage delta on src/protocols/http2/http2_client.cpp (still 18.75% line / 9.91% branch, byte-identical LH/LF/BRH/BRF pre vs post).

Related Issues

• Closes infra(test): add COVERAGE_TIMEOUT_MULTIPLIER for hermetic_transport_fixture wait_for (Round 5, Part of #1106, #953) #1112

Where

Affected call sites (lines pre-edit)

std::chrono::seconds(3) -> std::chrono::seconds(3) * NETWORK_COVERAGE_TIMEOUT_MULTIPLIER at lines:
633, 672, 744, 768, 793, 816, 848, 883, 907, 928, 948, 978, 1013, 1041, 1082, 1283, 1309, 1379, 1412, 1441, 1472, 1502, 1532, 1567 (24 sites).

request_timeout = std::chrono::milliseconds(2000) default arg in make_connected_client at line 722 -> scaled by multiplier (1 site).

The runtime client->set_timeout(std::chrono::milliseconds(2000)) at line 661 is intentionally untouched -- it configures the http2_client itself in a single-test scope and is not a wait budget.

How

Implementation

• Mechanical text substitution: every literal std::chrono::seconds(3) becomes std::chrono::seconds(3) * NETWORK_COVERAGE_TIMEOUT_MULTIPLIER.
• The macro is already visible via the existing #include "hermetic_transport_fixture.h" (line 36) which defines it with default value 1 and is overridden to 5 by tests/support/CMakeLists.txt under NETWORK_COVERAGE_BUILD.
• Off coverage (multiplier=1), expressions evaluate identically; semantics are unchanged.

Testing

• Debug and Release matrix CI must pass (semantics unchanged off coverage).
• Acceptance gate is post-merge coverage workflow on develop: line >=+20pp and branch >=+10pp delta on src/protocols/http2/http2_client.cpp versus the pre-merge sha. The PR landing here is necessary but not sufficient; a separate cron-triggered coverage workflow run will verify Round-5 success.

Breaking Changes

None.

Rollback

git revert -- test file only.

Closes #1112