refactor: consolidate adapter headers into umbrella files#600
Merged
Conversation
Create common_adapters.h, thread_adapters.h, and logger_adapters.h as consolidated entry points. Old per-direction and compatibility headers now redirect to the new umbrella files, preserving backward compatibility. Update CMakeLists.txt install rules.
Add changed entry for adapter file consolidation into umbrella headers.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates 8 bidirectional adapter files into 3 umbrella headers (
common_adapters.h,thread_adapters.h,logger_adapters.h) while maintaining full backward compatibility through existing include paths.Why
Fixes #599 -- The adapter layer had proliferated into many small files with overlapping concerns (e.g.,
common_monitor_adapter.h,common_system_adapter.h,monitoring_to_common_adapter.h,common_to_monitoring_adapter.h). Users had to know which specific file to include. Umbrella headers provide a single include point per subsystem.How
common_adapters.h: Consolidates common_system <-> monitoring_system adaptersthread_adapters.h: Consolidates thread_system adapters + backward-compatiblethread_system_adapteraliaslogger_adapters.h: Consolidates logger_system adapters + backward-compatiblelogger_system_adapteraliascommon_monitor_adapter.h,common_system_adapter.h,thread_system_adapter.h,logger_system_adapter.h) to include the new umbrella headersCMakeLists.txt: Updated install list to include all adapter headers (umbrella + individual + legacy)CHANGELOG.md: Added entry under "Changed"Backward Compatibility
Fully backward compatible -- All existing include paths continue to work. The legacy headers now redirect to the umbrella headers. Type aliases (
logger_system_adapter,thread_system_adapter) are preserved.