fix(deps): standardize logger_system find_dependency to snake_case#549
Merged
kcenon merged 1 commit intoMar 16, 2026
Merged
Conversation
- Fix cmake/monitoring_system-config.cmake.in to use find_dependency(logger_system) instead of find_dependency(LoggerSystem) to match portfile PACKAGE_NAME convention - Add find_package(logger_system CONFIG QUIET) fallback in CMakeLists.txt logger detection block, consistent with thread_system and network_system patterns Part of #532: Standardize CMake PACKAGE_NAME convention across ecosystem ports
5 tasks
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
) - Fix cmake/monitoring_system-config.cmake.in to use find_dependency(logger_system) instead of find_dependency(LoggerSystem) to match portfile PACKAGE_NAME convention - Add find_package(logger_system CONFIG QUIET) fallback in CMakeLists.txt logger detection block, consistent with thread_system and network_system patterns Part of #532: Standardize CMake PACKAGE_NAME convention across ecosystem ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
cmake/monitoring_system-config.cmake.inandCMakeLists.txtto use the snake_caselogger_systempackage name consistently, matching the established vcpkg PACKAGE_NAME convention.Changes
cmake/monitoring_system-config.cmake.in: Changefind_dependency(LoggerSystem CONFIG)→find_dependency(logger_system CONFIG)CMakeLists.txt: Addfind_package(logger_system CONFIG QUIET)fallback in the logger discovery block, consistent with howthread_systemandnetwork_systemare discoveredWhy
The logger_system portfile (
vcpkg-ports/kcenon-logger-system/portfile.cmake) usesPACKAGE_NAME logger_system(snake_case), but the config template was still callingfind_dependency(LoggerSystem CONFIG)(PascalCase). This causedfind_package(monitoring_system)to fail for consumers who hadlogger_systemenabled, because CMake would look for a non-existentLoggerSystempackage.Additionally, the logger discovery in
CMakeLists.txthad nofind_package()fallback — meaning vcpkg-installedlogger_systempackages would never be found during the initial dependency detection phase.Relates to #532: Standardize CMake PACKAGE_NAME convention across ecosystem ports
How
Root cause
find_dependency(LoggerSystem CONFIG)in the installed config file causedfind_package(monitoring_system)to fail when logger support was enabled andlogger_system(snake_case) was installed via vcpkg.Fix
find_dependencycall in config template with the portfile'sPACKAGE_NAMEfind_package(logger_system CONFIG QUIET)detection block (matches pattern used bythread_systemandnetwork_system)Testing
LoggerSystemandLoggerSystem::LoggerSystemfor submodule/FetchContent buildsChecklist
find_packagefallback added for vcpkg-mode logger discoveryCloses #532