refactor(buffer): make buffering_strategy use ring_buffer internally#316
Merged
Merged
Conversation
…312) - Refactor fixed_size_strategy, time_based_strategy, and adaptive_strategy to use ring_buffer<buffered_metric> for internal storage - Add detail::next_power_of_two() helper for ring_buffer capacity calculation - Keep priority_based_strategy with vector-based storage (requires sorting) - Update internal include paths to use relative paths for internal headers - Update test file include paths for consistency - Update CHANGELOG with changes
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…312) (#316) - Refactor fixed_size_strategy, time_based_strategy, and adaptive_strategy to use ring_buffer<buffered_metric> for internal storage - Add detail::next_power_of_two() helper for ring_buffer capacity calculation - Keep priority_based_strategy with vector-based storage (requires sorting) - Update internal include paths to use relative paths for internal headers - Update test file include paths for consistency - Update CHANGELOG with changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixed_size_strategy,time_based_strategy, andadaptive_strategyto usering_buffer<buffered_metric>for internal storage instead ofstd::vectordetail::next_power_of_two()helper function for ring_buffer capacity calculationpriority_based_strategywith vector-based storage (requires sorting/selective deletion operations not supported by ring_buffer)Changes
src/utils/buffering_strategy.hsrc/utils/buffer_manager.hsrc/utils/metric_storage.hsrc/utils/time_series.htests/test_buffering_strategies.cppdocs/CHANGELOG.mddocs/CHANGELOG_KO.mdTest plan
Related Issues
Closes #312