Skip to content

fix(vcpkg): complete overlay port for kcenon-common-system#287

Merged
kcenon merged 2 commits into
mainfrom
feature/281-vcpkg-common-system-overlay-port
Dec 29, 2025
Merged

fix(vcpkg): complete overlay port for kcenon-common-system#287
kcenon merged 2 commits into
mainfrom
feature/281-vcpkg-common-system-overlay-port

Conversation

@kcenon

@kcenon kcenon commented Dec 29, 2025

Copy link
Copy Markdown
Owner

Summary

  • Fix CMake option names in portfile.cmake to match upstream common_system
  • Update version to 0.2.0 to reflect actual upstream version
  • Update documentation with correct version information

Changes

portfile.cmake

  • Replace incorrect BUILD_TESTING, BUILD_BENCHMARKS with correct options:
    • COMMON_BUILD_TESTS
    • COMMON_BUILD_INTEGRATION_TESTS
    • COMMON_BUILD_EXAMPLES
    • COMMON_BUILD_BENCHMARKS
    • COMMON_BUILD_DOCS

vcpkg.json

  • Update version from 1.0.0 to 0.2.0 (matches upstream CMakeLists.txt)

Documentation

  • Update version in vcpkg-ports/README.md
  • Update version in docs/guides/VCPKG_OVERLAY_PORTS.md

Test Plan

  • CI passes all checks
  • vcpkg overlay port installation test (manual or CI)
  • Build test with overlay port

Related Issues

Closes #281

Notes

- Update portfile.cmake to use correct CMake option names
  - COMMON_BUILD_TESTS instead of BUILD_TESTING
  - COMMON_BUILD_INTEGRATION_TESTS for integration tests
  - COMMON_BUILD_EXAMPLES for examples
  - COMMON_BUILD_BENCHMARKS for benchmarks
  - COMMON_BUILD_DOCS for documentation
- Update version in vcpkg.json to match upstream (0.2.0)

Refs #281
Update version from 1.0.0 to 0.2.0 to match upstream CMakeLists.txt
- vcpkg-ports/README.md
- docs/guides/VCPKG_OVERLAY_PORTS.md

Refs #281
@kcenon kcenon merged commit e7f6da9 into main Dec 29, 2025
21 checks passed
@kcenon kcenon deleted the feature/281-vcpkg-common-system-overlay-port branch December 29, 2025 11:10
kcenon added a commit that referenced this pull request Apr 13, 2026
* fix(vcpkg): correct CMake options for kcenon-common-system overlay port

- Update portfile.cmake to use correct CMake option names
  - COMMON_BUILD_TESTS instead of BUILD_TESTING
  - COMMON_BUILD_INTEGRATION_TESTS for integration tests
  - COMMON_BUILD_EXAMPLES for examples
  - COMMON_BUILD_BENCHMARKS for benchmarks
  - COMMON_BUILD_DOCS for documentation
- Update version in vcpkg.json to match upstream (0.2.0)

Refs #281

* docs: update common-system version in vcpkg documentation

Update version from 1.0.0 to 0.2.0 to match upstream CMakeLists.txt
- vcpkg-ports/README.md
- docs/guides/VCPKG_OVERLAY_PORTS.md

Refs #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcpkg: Create overlay port for kcenon-common-system

1 participant