feat(config): adopt KCENON integration flags from common_system#272
Merged
Conversation
- Add feature_flags.h header for unified feature detection - Replace BUILD_WITH_COMMON_SYSTEM with KCENON_HAS_COMMON_SYSTEM - Include common_system's feature_flags.h for centralized flag management - Add legacy aliases for backward compatibility during migration - Update CMake compile definitions to use KCENON_HAS_COMMON_SYSTEM=1 - Update all header files to use #if KCENON_HAS_COMMON_SYSTEM pattern This aligns monitoring_system with the unified KCENON_* integration flag convention established in common_system. Closes #271
Remove the deprecated file/line/function 5-argument log() method overrides from mock logger classes. This API was removed from common_system's ILogger interface in v3.0.0 (Issue #217) in favor of the source_location-based API. Affected mock classes: - mock_logger in test_adapter_functionality.cpp - simple_mock_logger in test_cross_system_integration.cpp
Updated both English and Korean CHANGELOG files to document the removal of deprecated 5-argument log() method overrides from test mock classes.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
* feat(config): adopt KCENON integration flags from common_system - Add feature_flags.h header for unified feature detection - Replace BUILD_WITH_COMMON_SYSTEM with KCENON_HAS_COMMON_SYSTEM - Include common_system's feature_flags.h for centralized flag management - Add legacy aliases for backward compatibility during migration - Update CMake compile definitions to use KCENON_HAS_COMMON_SYSTEM=1 - Update all header files to use #if KCENON_HAS_COMMON_SYSTEM pattern This aligns monitoring_system with the unified KCENON_* integration flag convention established in common_system. Closes #271 * fix(tests): remove deprecated ILogger 5-arg log method overrides Remove the deprecated file/line/function 5-argument log() method overrides from mock logger classes. This API was removed from common_system's ILogger interface in v3.0.0 (Issue #217) in favor of the source_location-based API. Affected mock classes: - mock_logger in test_adapter_functionality.cpp - simple_mock_logger in test_cross_system_integration.cpp * docs(changelog): document deprecated ILogger API fix for PR #272 Updated both English and Korean CHANGELOG files to document the removal of deprecated 5-argument log() method overrides from test mock classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature_flags.hheader for unified feature detection in monitoring_systemBUILD_WITH_COMMON_SYSTEMwithKCENON_HAS_COMMON_SYSTEMacross all source filesBUILD_WITH_COMMON_SYSTEM,MONITORING_USING_COMMON_INTERFACES) for backward compatibilityChanges
New file:
include/kcenon/monitoring/config/feature_flags.hKCENON_HAS_COMMON_SYSTEMbased on header availabilityUpdated headers (8 files):
interfaces/event_bus_interface.hinterfaces/metric_collector_interface.hconcepts/monitoring_concepts.hdi/service_registration.hadapters/common_monitor_adapter.hadapters/common_system_adapter.hUpdated CMake:
CMakeLists.txt: UseKCENON_HAS_COMMON_SYSTEM=1compile definitionexamples/CMakeLists.txt: UseMONITORING_WITH_COMMON_SYSTEMvariablecmake/MonitoringLegacyOptions.cmake: Add documentation about new flag conventionUpdated tests:
tests/test_service_registration.cpp: Use feature_flags.h and KCENON_HAS_COMMON_SYSTEMTest plan
Closes #271