feat(vcpkg): standardize vcpkg.json following ecosystem conventions#267
Merged
Conversation
- Add gmock feature to gtest dependency for improved mock testing support - This completes the vcpkg.json standardization per ecosystem conventions Part of #265
gtest@1.14.0 in vcpkg includes gmock by default, no separate feature needed. This fixes Windows CI build failure.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…267) * feat(vcpkg): add gmock feature to gtest dependency in testing feature - Add gmock feature to gtest dependency for improved mock testing support - This completes the vcpkg.json standardization per ecosystem conventions Part of #265 * fix(vcpkg): remove gmock feature from gtest dependency gtest@1.14.0 in vcpkg includes gmock by default, no separate feature needed. This fixes Windows CI build failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
testingfeature to includegmockin gtest dependencyVerification
Notes
kcenon-common-systemdependency is handled via CMake'sUnifiedDependenciesmodule (FetchContent fallback) since it's not yet registered in vcpkgspdloginto thebenchmarksfeature only, matching the README documentation that states "spdlog is not used internally by logger_system"Acceptance Criteria from Issue #265
Closes #265