feat(vcpkg): standardize vcpkg.json following ecosystem conventions#266
Merged
Conversation
- Rename package from 'loggersystem' to 'kcenon-logger-system' - Add JSON schema for IDE validation and autocompletion - Add metadata: description, homepage, license, port-version, supports - Add kcenon-common-system as required dependency - Add 'async' feature with kcenon-thread-system dependency - Move spdlog to 'benchmarks' feature (comparison only, not core) - Add 'testing' feature with gtest dependency - Add fmt with version constraint Resolves #264
- Add vcpkg installation commands with feature flags - Clarify that spdlog is NOT used internally (benchmark comparison only) - Update fmt dependency to required with version constraint - Add note explaining spdlog's role in both EN/KO README Related to #264
- Remove kcenon-common-system and kcenon-thread-system from vcpkg.json (not yet registered in vcpkg registry, blocked by common_system#252) - Remove async feature (depends on unregistered kcenon-thread-system) - Update README to note ecosystem deps require CMake build for now - Keep vcpkg.json standardization (schema, metadata, license, etc.) These dependencies will be added once registered in vcpkg: - kcenon-common-system (blocked by: kcenon/common_system#252) - kcenon-thread-system (blocked by: kcenon/thread_system#348)
gtest@1.14.0 integrates gmock by default, separate feature no longer exists. This fixes Windows CI build failure.
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…266) * feat(vcpkg): standardize vcpkg.json following ecosystem conventions - Rename package from 'loggersystem' to 'kcenon-logger-system' - Add JSON schema for IDE validation and autocompletion - Add metadata: description, homepage, license, port-version, supports - Add kcenon-common-system as required dependency - Add 'async' feature with kcenon-thread-system dependency - Move spdlog to 'benchmarks' feature (comparison only, not core) - Add 'testing' feature with gtest dependency - Add fmt with version constraint Resolves #264 * docs: clarify spdlog role and add vcpkg installation guide - Add vcpkg installation commands with feature flags - Clarify that spdlog is NOT used internally (benchmark comparison only) - Update fmt dependency to required with version constraint - Add note explaining spdlog's role in both EN/KO README Related to #264 * fix(vcpkg): remove unregistered ecosystem deps for CI compatibility - Remove kcenon-common-system and kcenon-thread-system from vcpkg.json (not yet registered in vcpkg registry, blocked by common_system#252) - Remove async feature (depends on unregistered kcenon-thread-system) - Update README to note ecosystem deps require CMake build for now - Keep vcpkg.json standardization (schema, metadata, license, etc.) These dependencies will be added once registered in vcpkg: - kcenon-common-system (blocked by: kcenon/common_system#252) - kcenon-thread-system (blocked by: kcenon/thread_system#348) * fix(vcpkg): remove gmock feature from gtest dependency gtest@1.14.0 integrates gmock by default, separate feature no longer exists. This fixes Windows CI build failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
vcpkg.json Standardization
loggersystem→kcenon-logger-systemspdlogtobenchmarksfeature (comparison only)testingfeature with gtest dependencyfmtwith version constraint (>=10.0.0)Documentation Updates
vcpkg Features
Blocked Dependencies
The following ecosystem dependencies will be added once registered in vcpkg:
kcenon-common-system(blocked by: vcpkg: Standardize vcpkg.json and resolve documentation inconsistencies common_system#252)kcenon-thread-system(blocked by: vcpkg: Add missing common_system dependency and standardize vcpkg.json thread_system#348)asyncfeature (depends on kcenon-thread-system)Test Plan
Closes #264
Related to #265